[SPARK-17643] Remove comparable requirement from Offset (backport for branch-2.0) #15362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some sources, it is difficult to provide a global ordering based only on the data in the offset. Since we don't use comparison for correctness, lets remove it. Author: Michael Armbrust <michael@databricks.com> Closes #15207 from marmbrus/removeComparable.
Contributor
|
LGTM |
|
Test build #66402 has finished for PR 15362 at commit
|
Member
Author
|
Thanks! Merging to 2.0 |
asfgit
pushed a commit
that referenced
this pull request
Oct 5, 2016
… branch-2.0) ## What changes were proposed in this pull request? Backport 988c714 to branch-2.0 ## How was this patch tested? Jenkins Author: Michael Armbrust <michael@databricks.com> Closes #15362 from zsxwing/SPARK-17643-2.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Backport 988c714 to branch-2.0
How was this patch tested?
Jenkins