Skip to content

Conversation

@jiangxb1987
Copy link
Contributor

What changes were proposed in this pull request?

The function SparkSqlParserSuite.createTempViewUsing is not used for now and causes build failure, this PR simply removes it.

How was this patch tested?

N/A

@srowen
Copy link
Member

srowen commented Oct 10, 2016

Oops, yeah looks like this is a hotfix. Weird, because #14897 passed very recently. CC @cloud-fan ? not exactly sure if this is the cause.

[error] /home/jenkins/workspace/spark-master-test-maven-hadoop-2.6/sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala:126: not enough arguments for method apply: (tableIdent: org.apache.spark.sql.catalyst.TableIdentifier, userSpecifiedSchema: Option[org.apache.spark.sql.types.StructType], replace: Boolean, global: Boolean, provider: String, options: Map[String,String])org.apache.spark.sql.execution.datasources.CreateTempViewUsing in object CreateTempViewUsing.
[error] Unspecified value parameter options.
[error]     CreateTempViewUsing(TableIdentifier(table, database), schema, replace, provider, options)
[error]                        ^
[error] one error found
[error] Compile failed at Oct 10, 2016 1:21:13 AM [24.169s]

@cloud-fan
Copy link
Contributor

OK to test

@cloud-fan
Copy link
Contributor

it's due to a merge conflict(2 PRs do conflict but their code doesn't)

I'll merge this PR as soon as it pass the jenkins. @jiangxb1987 can you update the title to remove [minor] and add [hot-fix]?

@jiangxb1987 jiangxb1987 changed the title [MINOR][SQL][TESTS] Remove unused function in SparkSqlParserSuite [HOT-FIX][SQL][TESTS] Remove unused function in SparkSqlParserSuite Oct 10, 2016
@cloud-fan
Copy link
Contributor

ok to test

@cloud-fan
Copy link
Contributor

add to white list

@zhengruifeng
Copy link
Contributor

LGTM.

@SparkQA
Copy link

SparkQA commented Oct 10, 2016

Test build #66644 has finished for PR 15418 at commit e36479b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Oct 10, 2016

Test build #66642 has finished for PR 15418 at commit e36479b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Oct 10, 2016

Merged to master to unblock other PR tests

@asfgit asfgit closed this in 7e16c94 Oct 10, 2016
@jiangxb1987 jiangxb1987 deleted the parserSuite branch October 10, 2016 15:46
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
## What changes were proposed in this pull request?

The function `SparkSqlParserSuite.createTempViewUsing` is not used for now and causes build failure, this PR simply removes it.

## How was this patch tested?
N/A

Author: jiangxingbo <jiangxb1987@gmail.com>

Closes apache#15418 from jiangxb1987/parserSuite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants