-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-17882][SparkR] Fix swallowed exception in RBackendHandler #15446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @jrshust for the PR. Jenkins, ok to test |
|
@shivaram yes I just noticed it during my debugging and fixed it. |
|
Jenkins, test this please |
|
Hi @jrshust as mentioned above this fix is also included in the other earlier PR, which has just been merged. We appreciate your effort to fix this issue, and having a JIRA on this would be useful - I think I'll resolve this JIRA to your user account - if others are ok with this approach? |
|
@felixcheung Resolving the JIRA and assigning it to @jrshust sounds good to me. |
|
Hey thanks all. This sounds good to me. |
|
Test build #66831 has finished for PR 15446 at commit
|
|
Great - @jrshust what's your JIRA account? I think we need to add you as contributor before this JIRA can be resolved/assigned to you. |
|
@felixcheung jrshust as well. I'm the reporter of the JIRA ticket: https://issues.apache.org/jira/browse/SPARK-17882 |
|
I updated the JIRA. @jrshust could you close this PR ? We don't have permission to close PRs and only PR authors can do it |
|
yep. Closing since the fix is a duplicate of #15375. |
What changes were proposed in this pull request?
Log exception that is swallowed in handleMethodCall. This allows invoked Java issues to be easily debugged when using SparkR.
How was this patch tested?
Manual tests to verify the logged exception shows up.