Skip to content

Conversation

@jrshust
Copy link
Contributor

@jrshust jrshust commented Oct 12, 2016

What changes were proposed in this pull request?

Log exception that is swallowed in handleMethodCall. This allows invoked Java issues to be easily debugged when using SparkR.

How was this patch tested?

Manual tests to verify the logged exception shows up.

@jrshust jrshust changed the title [SPARK-17882][SPARKR] Fix swallowed exception in RBackendHandler [SPARK-17882][SparkR] Fix swallowed exception in RBackendHandler Oct 12, 2016
@shivaram
Copy link
Contributor

Thanks @jrshust for the PR.

Jenkins, ok to test

@shivaram
Copy link
Contributor

cc @falaki Is this also a part of #15375 ?

@falaki
Copy link
Contributor

falaki commented Oct 12, 2016

@shivaram yes I just noticed it during my debugging and fixed it.

@shivaram
Copy link
Contributor

Jenkins, test this please

@felixcheung
Copy link
Member

Hi @jrshust as mentioned above this fix is also included in the other earlier PR, which has just been merged.

We appreciate your effort to fix this issue, and having a JIRA on this would be useful - I think I'll resolve this JIRA to your user account - if others are ok with this approach?

@shivaram
Copy link
Contributor

@felixcheung Resolving the JIRA and assigning it to @jrshust sounds good to me.

@jrshust
Copy link
Contributor Author

jrshust commented Oct 12, 2016

Hey thanks all.

This sounds good to me.

@SparkQA
Copy link

SparkQA commented Oct 12, 2016

Test build #66831 has finished for PR 15446 at commit 083f57a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@felixcheung
Copy link
Member

Great - @jrshust what's your JIRA account? I think we need to add you as contributor before this JIRA can be resolved/assigned to you.

@jrshust
Copy link
Contributor Author

jrshust commented Oct 13, 2016

@felixcheung jrshust as well.

I'm the reporter of the JIRA ticket: https://issues.apache.org/jira/browse/SPARK-17882

@shivaram
Copy link
Contributor

I updated the JIRA. @jrshust could you close this PR ? We don't have permission to close PRs and only PR authors can do it

@jrshust
Copy link
Contributor Author

jrshust commented Oct 13, 2016

yep.

Closing since the fix is a duplicate of #15375.

@jrshust jrshust closed this Oct 13, 2016
@jrshust jrshust deleted the rbackend-logging branch October 13, 2016 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants