[SPARK-18425][Structured Streaming][Tests] Test CompactibleFileStreamLog directly
#15870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #68580 has finished for PR 15870 at commit
|
Contributor
Author
|
To make it easier to review, this patch was made of two commits:
|
Member
|
Thanks for doing this. Could you resolve the conflicts, please? |
Contributor
Author
|
@zsxwing thanks. I'm rebasing right now. |
lw-lin
force-pushed
the
test-compact-1113
branch
from
3014a03 to
bb5ab33
Compare
|
Test build #68879 has finished for PR 15870 at commit
|
zsxwing
requested changes
Nov 21, 2016
| import java.nio.charset.StandardCharsets._ | ||
|
|
||
| class CompactibleFileStreamLogSuite extends SparkFunSuite { | ||
| import scala.language.implicitConversions |
|
Test build #68973 has finished for PR 15870 at commit
|
Member
|
LGTM. Thanks! Merging to master and 2.1. |
asfgit
pushed a commit
that referenced
this pull request
Nov 22, 2016
…mLog` directly ## What changes were proposed in this pull request? Right now we are testing the most of `CompactibleFileStreamLog` in `FileStreamSinkLogSuite` (because `FileStreamSinkLog` once was the only subclass of `CompactibleFileStreamLog`, but now it's not the case any more). Let's refactor the tests so that `CompactibleFileStreamLog` is directly tested, making future changes (like #15828, #15827) to `CompactibleFileStreamLog` much easier to test and much easier to review. ## How was this patch tested? the PR itself is about tests Author: Liwei Lin <lwlin7@gmail.com> Closes #15870 from lw-lin/test-compact-1113. (cherry picked from commit ebeb083) Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Dec 2, 2016
…mLog` directly ## What changes were proposed in this pull request? Right now we are testing the most of `CompactibleFileStreamLog` in `FileStreamSinkLogSuite` (because `FileStreamSinkLog` once was the only subclass of `CompactibleFileStreamLog`, but now it's not the case any more). Let's refactor the tests so that `CompactibleFileStreamLog` is directly tested, making future changes (like apache#15828, apache#15827) to `CompactibleFileStreamLog` much easier to test and much easier to review. ## How was this patch tested? the PR itself is about tests Author: Liwei Lin <lwlin7@gmail.com> Closes apache#15870 from lw-lin/test-compact-1113.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…mLog` directly ## What changes were proposed in this pull request? Right now we are testing the most of `CompactibleFileStreamLog` in `FileStreamSinkLogSuite` (because `FileStreamSinkLog` once was the only subclass of `CompactibleFileStreamLog`, but now it's not the case any more). Let's refactor the tests so that `CompactibleFileStreamLog` is directly tested, making future changes (like apache#15828, apache#15827) to `CompactibleFileStreamLog` much easier to test and much easier to review. ## How was this patch tested? the PR itself is about tests Author: Liwei Lin <lwlin7@gmail.com> Closes apache#15870 from lw-lin/test-compact-1113.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Right now we are testing the most of
CompactibleFileStreamLoginFileStreamSinkLogSuite(becauseFileStreamSinkLogonce was the only subclass ofCompactibleFileStreamLog, but now it's not the case any more).Let's refactor the tests so that
CompactibleFileStreamLogis directly tested, making future changes (like #15828, #15827) toCompactibleFileStreamLogmuch easier to test and much easier to review.How was this patch tested?
the PR itself is about tests