[SPARK-18459][SPARK-18460][StructuredStreaming] Rename triggerId to batchId and add triggerDetails to json in StreamingQueryStatus #15895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdas
changed the title
tdas
commented
Nov 16, 2016
| ("processingRate" -> JDouble(processingRate)) ~ | ||
| ("latency" -> latency.map(JDouble).getOrElse(JNothing)) ~ | ||
| ("triggerDetails" -> JsonProtocol.mapToJson(triggerDetails.asScala)) | ||
| ("triggerDetails" -> JsonProtocol.mapToJson(triggerDetails.asScala)) ~ |
Contributor
Author
There was a problem hiding this comment.
This is the fix for triggerDetails not being in the status.json.
tdas
changed the title
tdas
changed the title
|
Test build #68681 has finished for PR 15895 at commit
|
|
Test build #68682 has finished for PR 15895 at commit
|
|
Test build #68713 has finished for PR 15895 at commit
|
Member
|
LGTM. Merging to master, 2.1 and 2.0. |
asfgit
pushed a commit
that referenced
this pull request
Nov 16, 2016
…atchId and add triggerDetails to json in StreamingQueryStatus ## What changes were proposed in this pull request? SPARK-18459: triggerId seems like a number that should be increasing with each trigger, whether or not there is data in it. However, actually, triggerId increases only where there is a batch of data in a trigger. So its better to rename it to batchId. SPARK-18460: triggerDetails was missing from json representation. Fixed it. ## How was this patch tested? Updated existing unit tests. Author: Tathagata Das <tathagata.das1565@gmail.com> Closes #15895 from tdas/SPARK-18459. (cherry picked from commit 0048ce7) Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
Member
|
Oh, merge conflicts with 2.0. Could you submit a PR for 2.0? |
asfgit
pushed a commit
that referenced
this pull request
Nov 16, 2016
…atchId and add triggerDetails to json in StreamingQueryStatus (for branch-2.0) This is a fix for branch-2.0 for the earlier PR #15895 ## What changes were proposed in this pull request? SPARK-18459: triggerId seems like a number that should be increasing with each trigger, whether or not there is data in it. However, actually, triggerId increases only where there is a batch of data in a trigger. So its better to rename it to batchId. SPARK-18460: triggerDetails was missing from json representation. Fixed it. ## How was this patch tested? Updated tests Author: Tathagata Das <tathagata.das1565@gmail.com> Closes #15908 from tdas/SPARK-18459-2.0.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
…atchId and add triggerDetails to json in StreamingQueryStatus ## What changes were proposed in this pull request? SPARK-18459: triggerId seems like a number that should be increasing with each trigger, whether or not there is data in it. However, actually, triggerId increases only where there is a batch of data in a trigger. So its better to rename it to batchId. SPARK-18460: triggerDetails was missing from json representation. Fixed it. ## How was this patch tested? Updated existing unit tests. Author: Tathagata Das <tathagata.das1565@gmail.com> Closes apache#15895 from tdas/SPARK-18459.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SPARK-18459: triggerId seems like a number that should be increasing with each trigger, whether or not there is data in it. However, actually, triggerId increases only where there is a batch of data in a trigger. So its better to rename it to batchId.
SPARK-18460: triggerDetails was missing from json representation. Fixed it.
How was this patch tested?
Updated existing unit tests.