Skip to content

Conversation

@zhengruifeng
Copy link
Contributor

What changes were proposed in this pull request?

1, There are two [Graph.partitionBy] in graphx-programming-guide.md, the first one had no effert.
2, DataFrame, Transformer, Pipeline and Parameter in ml-pipeline.md were linked to ml-guide.html by mistake.
3, PythonMLLibAPI in mllib-linear-methods.md was not accessable, because class PythonMLLibAPI is private.
4, Other link updates.

How was this patch tested?

manual tests

@SparkQA
Copy link

SparkQA commented Nov 17, 2016

Test build #68740 has finished for PR 15912 at commit 8518730.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this class is imported, is it better to write [[LabeledPoint]]? Likewise for other class links here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will update this.

@SparkQA
Copy link

SparkQA commented Nov 17, 2016

Test build #68772 has finished for PR 15912 at commit 1c7d8fe.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Nov 17, 2016

Merged to master/2.1

@asfgit asfgit closed this in cdaf4ce Nov 17, 2016
asfgit pushed a commit that referenced this pull request Nov 17, 2016
## What changes were proposed in this pull request?
1, There are two `[Graph.partitionBy]` in `graphx-programming-guide.md`, the first one had no effert.
2, `DataFrame`, `Transformer`, `Pipeline` and `Parameter`  in `ml-pipeline.md` were linked to `ml-guide.html` by mistake.
3, `PythonMLLibAPI` in `mllib-linear-methods.md` was not accessable, because class `PythonMLLibAPI` is private.
4, Other link updates.
## How was this patch tested?
 manual tests

Author: Zheng RuiFeng <ruifengz@foxmail.com>

Closes #15912 from zhengruifeng/md_fix.

(cherry picked from commit cdaf4ce)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@zhengruifeng zhengruifeng deleted the md_fix branch November 18, 2016 01:43
uzadude pushed a commit to uzadude/spark that referenced this pull request Jan 27, 2017
## What changes were proposed in this pull request?
1, There are two `[Graph.partitionBy]` in `graphx-programming-guide.md`, the first one had no effert.
2, `DataFrame`, `Transformer`, `Pipeline` and `Parameter`  in `ml-pipeline.md` were linked to `ml-guide.html` by mistake.
3, `PythonMLLibAPI` in `mllib-linear-methods.md` was not accessable, because class `PythonMLLibAPI` is private.
4, Other link updates.
## How was this patch tested?
 manual tests

Author: Zheng RuiFeng <ruifengz@foxmail.com>

Closes apache#15912 from zhengruifeng/md_fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants