-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-20720][WEB-UI]'Executor Summary' should show the exact number, 'Removed Executors' should display the specific number, in the Application Page #17961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ucceeded|failed|unknown]
…remove redundant description.
…d Executors' should display the specific number, in the Application Page
|
Can one of the admins verify this patch? |
|
@srowen @ajbozarth |
|
If this would be useful I don't see any harm in adding it, its a pretty small change |
|
Hm, but do we do this consistently in the UI? show "Thing (count)"? it needs to be uniform if it's changed. |
|
@srowen The first style is to display statistics separately, as follows: The second style is displayed in the table header, with parentheses, as follows: I am modifying this issue by using the second style. |
|
I see. I think the first style exists to provide links that jump to running apps because it may be well below the fold if there are many workers. I think that can stay, even though the design of this little header is not great and wastes a lot of white space at the right. I think it'd be nice to add (count) to all the tables of things in the UI, as I assume that's pretty easy to do, isn't obtrusive, and would make it more consistent. I suppose that goes for stages, tasks, etc. What do you think? |
|
Yes, I agree with you. I will work on it. |
|
I like it, I think limiting this particular pr to updating the master ui is probably best for now, could you also update |
|
@ajbozarth @srowen |
|
Thanks for checking @guoxiaolongzte looks like with this fix every table will now have a (count) LGTM |
|
Merged to master |
… 'Removed Executors' should display the specific number, in the Application Page ## What changes were proposed in this pull request? When the number of spark worker executors is large, if the specific number is displayed, will better help us to analyze and observe by spark ui. Although this is a small improvement, but it is indeed very valuable. After fix:  ## How was this patch tested? manual tests Please review http://spark.apache.org/contributing.html before opening a pull request. Author: guoxiaolong <guo.xiaolong1@zte.com.cn> Author: 郭小龙 10207633 <guo.xiaolong1@zte.com.cn> Author: guoxiaolongzte <guo.xiaolong1@zte.com.cn> Closes apache#17961 from guoxiaolongzte/SPARK-20720.
… 'Removed Executors' should display the specific number, in the Application Page ## What changes were proposed in this pull request? When the number of spark worker executors is large, if the specific number is displayed, will better help us to analyze and observe by spark ui. Although this is a small improvement, but it is indeed very valuable. After fix:  ## How was this patch tested? manual tests Please review http://spark.apache.org/contributing.html before opening a pull request. Author: guoxiaolong <guo.xiaolong1@zte.com.cn> Author: 郭小龙 10207633 <guo.xiaolong1@zte.com.cn> Author: guoxiaolongzte <guo.xiaolong1@zte.com.cn> Closes apache#17961 from guoxiaolongzte/SPARK-20720.







What changes were proposed in this pull request?
When the number of spark worker executors is large, if the specific number is displayed, will better help us to analyze and observe by spark ui.
Although this is a small improvement, but it is indeed very valuable.
After fix:

How was this patch tested?
manual tests
Please review http://spark.apache.org/contributing.html before opening a pull request.