Skip to content

Conversation

@guoxiaolongzte
Copy link

@guoxiaolongzte guoxiaolongzte commented May 12, 2017

What changes were proposed in this pull request?

When the number of spark worker executors is large, if the specific number is displayed, will better help us to analyze and observe by spark ui.

Although this is a small improvement, but it is indeed very valuable.

After fix:
executor1

How was this patch tested?

manual tests

Please review http://spark.apache.org/contributing.html before opening a pull request.

郭小龙 10207633 added 27 commits March 31, 2017 21:57
…d Executors' should display the specific number, in the Application Page
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@guoxiaolongzte
Copy link
Author

@srowen @ajbozarth
Help to review the code, thanks.

@ajbozarth
Copy link
Member

If this would be useful I don't see any harm in adding it, its a pretty small change

@srowen
Copy link
Member

srowen commented May 12, 2017

Hm, but do we do this consistently in the UI? show "Thing (count)"? it needs to be uniform if it's changed.

@guoxiaolongzte
Copy link
Author

guoxiaolongzte commented May 12, 2017

@srowen
As far as I know, we spark ui have two styles.

The first style is to display statistics separately, as follows:
first

The second style is displayed in the table header, with parentheses, as follows:
second

I am modifying this issue by using the second style.

@srowen
Copy link
Member

srowen commented May 12, 2017

I see. I think the first style exists to provide links that jump to running apps because it may be well below the fold if there are many workers. I think that can stay, even though the design of this little header is not great and wastes a lot of white space at the right.

I think it'd be nice to add (count) to all the tables of things in the UI, as I assume that's pretty easy to do, isn't obtrusive, and would make it more consistent. I suppose that goes for stages, tasks, etc. What do you think?

@guoxiaolongzte
Copy link
Author

Yes, I agree with you. I will work on it.

@ajbozarth
Copy link
Member

I like it, I think limiting this particular pr to updating the master ui is probably best for now, could you also update WorkerPage.scala as well since its part of the "Master UI"

@guoxiaolongzte
Copy link
Author

guoxiaolongzte commented May 12, 2017

@ajbozarth @srowen
At present my branch code ui about 'count ' to table , test results:
1.master page by i fix, as follows:
master

2.job page , as follows:
job

3.stage page , as follows:
stage

4.task page, as follows:
task

5.work page, as follows:
work

@ajbozarth
Copy link
Member

Thanks for checking @guoxiaolongzte looks like with this fix every table will now have a (count)

LGTM

@srowen
Copy link
Member

srowen commented May 15, 2017

Merged to master

@asfgit asfgit closed this in 8da6e8b May 15, 2017
robert3005 pushed a commit to palantir/spark that referenced this pull request May 19, 2017
… 'Removed Executors' should display the specific number, in the Application Page

## What changes were proposed in this pull request?

When the number of spark worker executors is large, if the specific number is displayed, will better help us to analyze and observe by spark ui.

Although this is a small improvement, but it is indeed very valuable.

After fix:
![executor1](https://cloud.githubusercontent.com/assets/26266482/25986597/2d8e4386-3723-11e7-9c24-e5bff17c26e2.png)

## How was this patch tested?

manual tests

Please review http://spark.apache.org/contributing.html before opening a pull request.

Author: guoxiaolong <guo.xiaolong1@zte.com.cn>
Author: 郭小龙 10207633 <guo.xiaolong1@zte.com.cn>
Author: guoxiaolongzte <guo.xiaolong1@zte.com.cn>

Closes apache#17961 from guoxiaolongzte/SPARK-20720.
lycplus pushed a commit to lycplus/spark that referenced this pull request May 24, 2017
… 'Removed Executors' should display the specific number, in the Application Page

## What changes were proposed in this pull request?

When the number of spark worker executors is large, if the specific number is displayed, will better help us to analyze and observe by spark ui.

Although this is a small improvement, but it is indeed very valuable.

After fix:
![executor1](https://cloud.githubusercontent.com/assets/26266482/25986597/2d8e4386-3723-11e7-9c24-e5bff17c26e2.png)

## How was this patch tested?

manual tests

Please review http://spark.apache.org/contributing.html before opening a pull request.

Author: guoxiaolong <guo.xiaolong1@zte.com.cn>
Author: 郭小龙 10207633 <guo.xiaolong1@zte.com.cn>
Author: guoxiaolongzte <guo.xiaolong1@zte.com.cn>

Closes apache#17961 from guoxiaolongzte/SPARK-20720.
@guoxiaolongzte guoxiaolongzte deleted the SPARK-20720 branch June 12, 2017 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants