Skip to content

[SPARK-21339] [CORE] spark-shell --packages option does not add jars to classpath on windows #18708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
devaraj-kavali wants to merge 2 commits into from
Closed

[SPARK-21339] [CORE] spark-shell --packages option does not add jars to classpath on windows #18708

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3242532
[SPARK-21339] [CORE] spark-shell --packages option does not add jars to
Jul 21, 2017
025e484
Removing the file:/ scheme from each jar before setting into classpath
Jul 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion repl/scala-2.11/src/main/scala/org/apache/spark/repl/Main.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
package org.apache.spark.repl

import java.io.File
import java.net.URI
import java.util.Locale

import scala.tools.nsc.GenericRunnerSettings
Expand Down Expand Up @@ -56,7 +57,10 @@ object Main extends Logging {
// Visible for testing
private[repl] def doMain(args: Array[String], _interp: SparkILoop): Unit = {
interp = _interp
val jars = Utils.getUserJars(conf, isShell = true).mkString(File.pathSeparator)
val jars = Utils.getUserJars(conf, isShell = true)
// Remove file:///, file:// or file:/ scheme if exists for each jar
.map(x => if (x.startsWith("file:")) new File(new URI(x)).getPath else x)
.mkString(File.pathSeparator)
val interpArguments = List(
"-Yrepl-class-based",
"-Yrepl-outdir", s"${outputDir.getAbsolutePath}",
Expand Down