Skip to content

Conversation

@christiam
Copy link
Contributor

What changes were proposed in this pull request?

Add missing import and missing parentheses to invoke SparkSession::text().

How was this patch tested?

Built and the code for this application, ran jekyll locally per docs/README.md.

<name>Simple Project</name>
<packaging>jar</packaging>
<version>1.0</version>
<properties>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not giving the complete Maven config here, and Java 8 is required, so that's one of many pieces of config I think we assume the user will fill in. (Anyway, this is probably better specified by configuring the compiler plugin directly)?

But I agree with the two changes above. Any other bits of Java example with a similar problem?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any other bits of Java example with a similar problem?

Not that I'm currently aware of.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see two other instances in structured-streaming-programming-guide.md around line 1044.
If you can address those and remove this stanza, I'll merge

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you can address those and remove this stanza, I'll merge.

This is done.

@SparkQA
Copy link

SparkQA commented Aug 3, 2017

Test build #3877 has finished for PR 18795 at commit 7471781.

  • This patch fails SparkR unit tests.
  • This patch does not merge cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 3, 2017

Test build #3878 has finished for PR 18795 at commit 7471781.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Aug 3, 2017

Merged to master/2.2

@asfgit asfgit closed this in dd72b10 Aug 3, 2017
asfgit pushed a commit that referenced this pull request Aug 3, 2017
## What changes were proposed in this pull request?

Add missing import and missing parentheses to invoke `SparkSession::text()`.

## How was this patch tested?

Built and the code for this application, ran jekyll locally per docs/README.md.

Author: Christiam Camacho <camacho@ncbi.nlm.nih.gov>

Closes #18795 from christiam/master.

(cherry picked from commit dd72b10)
Signed-off-by: Sean Owen <sowen@cloudera.com>
MatthewRBruce pushed a commit to Shopify/spark that referenced this pull request Jul 31, 2018
## What changes were proposed in this pull request?

Add missing import and missing parentheses to invoke `SparkSession::text()`.

## How was this patch tested?

Built and the code for this application, ran jekyll locally per docs/README.md.

Author: Christiam Camacho <camacho@ncbi.nlm.nih.gov>

Closes apache#18795 from christiam/master.

(cherry picked from commit dd72b10)
Signed-off-by: Sean Owen <sowen@cloudera.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants