-
Notifications
You must be signed in to change notification settings - Fork 29k
Fix Java SimpleApp spark application #18795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/quick-start.md
Outdated
| <name>Simple Project</name> | ||
| <packaging>jar</packaging> | ||
| <version>1.0</version> | ||
| <properties> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not giving the complete Maven config here, and Java 8 is required, so that's one of many pieces of config I think we assume the user will fill in. (Anyway, this is probably better specified by configuring the compiler plugin directly)?
But I agree with the two changes above. Any other bits of Java example with a similar problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any other bits of Java example with a similar problem?
Not that I'm currently aware of.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see two other instances in structured-streaming-programming-guide.md around line 1044.
If you can address those and remove this stanza, I'll merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can address those and remove this stanza, I'll merge.
This is done.
|
Test build #3877 has finished for PR 18795 at commit
|
|
Test build #3878 has finished for PR 18795 at commit
|
|
Merged to master/2.2 |
## What changes were proposed in this pull request? Add missing import and missing parentheses to invoke `SparkSession::text()`. ## How was this patch tested? Built and the code for this application, ran jekyll locally per docs/README.md. Author: Christiam Camacho <camacho@ncbi.nlm.nih.gov> Closes #18795 from christiam/master. (cherry picked from commit dd72b10) Signed-off-by: Sean Owen <sowen@cloudera.com>
## What changes were proposed in this pull request? Add missing import and missing parentheses to invoke `SparkSession::text()`. ## How was this patch tested? Built and the code for this application, ran jekyll locally per docs/README.md. Author: Christiam Camacho <camacho@ncbi.nlm.nih.gov> Closes apache#18795 from christiam/master. (cherry picked from commit dd72b10) Signed-off-by: Sean Owen <sowen@cloudera.com>
What changes were proposed in this pull request?
Add missing import and missing parentheses to invoke
SparkSession::text().How was this patch tested?
Built and the code for this application, ran jekyll locally per docs/README.md.