[SPARK-21374][CORE] Fix reading globbed paths from S3 into DF with disabled FS cache #18848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsxwing
commented
Aug 4, 2017
| * If `path` is a file pattern, return all the files that match it. Otherwise, return itself. | ||
| * If `checkFilesExist` is `true`, also check the file existence. | ||
| */ | ||
| private def checkAndGlobPathIfNecessary( |
Member
Author
There was a problem hiding this comment.
Created a new method to make the codes cleaner.
Member
Author
|
cc @gatorsmile |
gatorsmile
approved these changes
Aug 4, 2017
Member
|
LGTM pending Jenkins |
|
Test build #80263 has finished for PR 18848 at commit
|
Member
|
Thanks! Merging to master. |
Member
Author
|
Also merged to branch-2.2. |
MatthewRBruce
pushed a commit
to Shopify/spark
that referenced
this pull request
Jul 31, 2018
…sabled FS cache This PR replaces apache#18623 to do some clean up. Closes apache#18623 Jenkins Author: Shixiong Zhu <shixiong@databricks.com> Author: Andrey Taptunov <taptunov@amazon.com> Closes apache#18848 from zsxwing/review-pr18623.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR replaces #18623 to do some clean up.
Closes #18623
How was this patch tested?
Jenkins