[SPARK-25278][SQL][followup] remove the hack in ProgressReporter #22380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
mgaido91
reviewed
Sep 10, 2018
Contributor
mgaido91
left a comment
mgaido91
left a comment
There was a problem hiding this comment.
I am not familiar with this part of the code, but this dedup logic is indeed not needed anymore.
I am just wondering how could this work (pass UTs) for the DSv1, as I see no dedup logic there. Do you have any idea?
Contributor
Author
|
ok to test |
|
Test build #95878 has finished for PR 22380 at commit
|
|
Test build #95875 has finished for PR 22380 at commit
|
Contributor
Author
|
thanks, merging to master! |
fjh100456
pushed a commit
to fjh100456/spark
that referenced
this pull request
Sep 13, 2018
## What changes were proposed in this pull request? It turns out it's a bug that a `DataSourceV2ScanExec` instance may be referred to in the execution plan multiple times. This bug is fixed by apache#22284 and now we have corrected SQL metrics for batch queries. Thus we don't need the hack in `ProgressReporter` anymore, which fixes the same metrics problem for streaming queries. ## How was this patch tested? existing tests Closes apache#22380 from cloud-fan/followup. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
It turns out it's a bug that a
DataSourceV2ScanExecinstance may be referred to in the execution plan multiple times. This bug is fixed by #22284 and now we have corrected SQL metrics for batch queries.Thus we don't need the hack in
ProgressReporteranymore, which fixes the same metrics problem for streaming queries.How was this patch tested?
existing tests