Skip to content

Conversation

@gengliangwang
Copy link
Member

What changes were proposed in this pull request?

When the URL for description column in the table of job/stage page is long, WebUI doesn't render it properly.

beforefix

Both job and stage page are using the class name-link for the description URL, so change the style of a.name-link to fix it.

How was this patch tested?

Manual test on my local:
afterfix

@gengliangwang
Copy link
Member Author

@srowen @vanzin

@SparkQA
Copy link

SparkQA commented Oct 16, 2018

Test build #97449 has finished for PR 22744 at commit 9967c02.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Oct 17, 2018

Merged to master/2.4

asfgit pushed a commit that referenced this pull request Oct 17, 2018
## What changes were proposed in this pull request?

When the URL for description column in the table of job/stage page is long, WebUI doesn't render it properly.

![beforefix](https://user-images.githubusercontent.com/1097932/47009242-9323ba00-d16e-11e8-8262-0848d814442a.jpeg)

Both job and stage page are using the class `name-link` for the description URL,  so change the style of `a.name-link` to fix it.

## How was this patch tested?

Manual test on my local:
![afterfix](https://user-images.githubusercontent.com/1097932/47009269-a46cc680-d16e-11e8-9ff5-0318a20db634.jpeg)

Closes #22744 from gengliangwang/fixUILink.

Authored-by: Gengliang Wang <gengliang.wang@databricks.com>
Signed-off-by: Sean Owen <sean.owen@databricks.com>
(cherry picked from commit 1901f06)
Signed-off-by: Sean Owen <sean.owen@databricks.com>
@asfgit asfgit closed this in 1901f06 Oct 17, 2018
jackylee-ch pushed a commit to jackylee-ch/spark that referenced this pull request Feb 18, 2019
## What changes were proposed in this pull request?

When the URL for description column in the table of job/stage page is long, WebUI doesn't render it properly.

![beforefix](https://user-images.githubusercontent.com/1097932/47009242-9323ba00-d16e-11e8-8262-0848d814442a.jpeg)

Both job and stage page are using the class `name-link` for the description URL,  so change the style of `a.name-link` to fix it.

## How was this patch tested?

Manual test on my local:
![afterfix](https://user-images.githubusercontent.com/1097932/47009269-a46cc680-d16e-11e8-9ff5-0318a20db634.jpeg)

Closes apache#22744 from gengliangwang/fixUILink.

Authored-by: Gengliang Wang <gengliang.wang@databricks.com>
Signed-off-by: Sean Owen <sean.owen@databricks.com>
zzcclp added a commit to zzcclp/spark that referenced this pull request Sep 20, 2019
apache#22744

When the URL for description column in the table of job/stage page is long, WebUI doesn't render it properly.

Both job and stage page are using the class name-link for the description URL, so change the style of a.name-link to fix it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants