Skip to content

Conversation

@brndnmtthws
Copy link
Member

The MesosSchedulerBackend did not previously implement killTask,
resulting in an exception.

@rxin
Copy link
Contributor

rxin commented Sep 19, 2014

Sorry for asking - but have you tested this on a real cluster?

@rxin
Copy link
Contributor

rxin commented Sep 19, 2014

Oh and thanks for doing this!

@brndnmtthws
Copy link
Member Author

I did indeed test it, and it worked as expected.

@SparkQA
Copy link

SparkQA commented Sep 19, 2014

Can one of the admins verify this patch?

@andrewor14
Copy link
Contributor

ok to test

@andrewor14
Copy link
Contributor

There is a related PR #1940

@andrewor14
Copy link
Contributor

test this please

@SparkQA
Copy link

SparkQA commented Sep 26, 2014

QA tests have started for PR 2453 at commit 40c4478.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 26, 2014

QA tests have finished for PR 2453 at commit 40c4478.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class IDF(val minDocFreq: Int)
    • class DocumentFrequencyAggregator(val minDocFreq: Int) extends Serializable
    • class PStatsParam(AccumulatorParam):

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20872/

@brndnmtthws
Copy link
Member Author

Build error appears to be unrelated to my patch.

@JoshRosen
Copy link
Contributor

Build failure is my fault, due to merging #2351. I've reverted it and re-triggered your unit tests.

@brndnmtthws
Copy link
Member Author

Okay, I'll rebase.

The MesosSchedulerBackend did not previously implement `killTask`,
resulting in an exception.
@SparkQA
Copy link

SparkQA commented Sep 26, 2014

QA tests have started for PR 2453 at commit 40c4478.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 26, 2014

QA tests have started for PR 2453 at commit 23ddcdc.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 26, 2014

QA tests have finished for PR 2453 at commit 40c4478.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class IDF(val minDocFreq: Int)
    • class DocumentFrequencyAggregator(val minDocFreq: Int) extends Serializable

@SparkQA
Copy link

SparkQA commented Sep 26, 2014

QA tests have finished for PR 2453 at commit 23ddcdc.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/20882/

@brndnmtthws
Copy link
Member Author

This code has been tested & verified on a cluster of this size:

screen shot 2014-10-02 at 11 13 57 am

@andrewor14
Copy link
Contributor

LGTM, but I'm no expert on the mesos integration. @tnachen any comments?

@JoshRosen
Copy link
Contributor

This looks good to me. I tested this patch against Mesos 0.20.1 running in Docker with a modified version of a test from Spark's JobCancellationSuite .

@tnachen commented on this over at #1940 (comment):

On Mesos side if you call killTask on a non-existing Task all you get is a LOG(WARNING).

@andrewor14
Copy link
Contributor

Alright, thanks for testing @JoshRosen and @brndnmtthws. I'm merging this into master and 1.1.

asfgit pushed a commit that referenced this pull request Oct 5, 2014
The MesosSchedulerBackend did not previously implement `killTask`,
resulting in an exception.

Author: Brenden Matthews <brenden@diddyinc.com>

Closes #2453 from brndnmtthws/implement-killtask and squashes the following commits:

23ddcdc [Brenden Matthews] [SPARK-3597][Mesos] Implement `killTask`.

(cherry picked from commit 32fad42)
Signed-off-by: Andrew Or <andrewor14@gmail.com>
@asfgit asfgit closed this in 32fad42 Oct 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants