-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-3597][Mesos] Implement killTask.
#2453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Sorry for asking - but have you tested this on a real cluster? |
|
Oh and thanks for doing this! |
|
I did indeed test it, and it worked as expected. |
|
Can one of the admins verify this patch? |
|
ok to test |
|
There is a related PR #1940 |
|
test this please |
|
QA tests have started for PR 2453 at commit
|
|
QA tests have finished for PR 2453 at commit
|
|
Test FAILed. |
|
Build error appears to be unrelated to my patch. |
|
Build failure is my fault, due to merging #2351. I've reverted it and re-triggered your unit tests. |
|
Okay, I'll rebase. |
The MesosSchedulerBackend did not previously implement `killTask`, resulting in an exception.
40c4478 to
23ddcdc
Compare
|
QA tests have started for PR 2453 at commit
|
|
QA tests have started for PR 2453 at commit
|
|
QA tests have finished for PR 2453 at commit
|
|
QA tests have finished for PR 2453 at commit
|
|
Test PASSed. |
|
LGTM, but I'm no expert on the mesos integration. @tnachen any comments? |
|
This looks good to me. I tested this patch against Mesos 0.20.1 running in Docker with a modified version of a test from Spark's JobCancellationSuite . @tnachen commented on this over at #1940 (comment):
|
|
Alright, thanks for testing @JoshRosen and @brndnmtthws. I'm merging this into master and 1.1. |
The MesosSchedulerBackend did not previously implement `killTask`, resulting in an exception. Author: Brenden Matthews <brenden@diddyinc.com> Closes #2453 from brndnmtthws/implement-killtask and squashes the following commits: 23ddcdc [Brenden Matthews] [SPARK-3597][Mesos] Implement `killTask`. (cherry picked from commit 32fad42) Signed-off-by: Andrew Or <andrewor14@gmail.com>

The MesosSchedulerBackend did not previously implement
killTask,resulting in an exception.