Skip to content

[SPARK-28062][ML] Avoid unnecessary copy of coefficients vector in HuberAggregator #24880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Andrew-Crosby wants to merge 2 commits into from
Closed

[SPARK-28062][ML] Avoid unnecessary copy of coefficients vector in HuberAggregator #24880

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b835c53
Avoid unnecessary copy of coefficients vector each time an instance i…
Andrew-Crosby Jun 15, 2019
cdb49c0
Revert unnecessary change
Andrew-Crosby Jun 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion mllib/src/main/scala/org/apache/spark/ml/optim/aggregator/HuberAggregator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ private[ml] class HuberAggregator(
} else {
0.0
}
// make transient so we do not serialize between aggregation stages
@transient private lazy val coefficients = bcParameters.value.toArray.slice(0, numFeatures)

/**
* Add a new training instance to this HuberAggregator, and update the loss and gradient
Expand All @@ -97,7 +99,7 @@ private[ml] class HuberAggregator(

if (weight == 0.0) return this
val localFeaturesStd = bcFeaturesStd.value
val localCoefficients = bcParameters.value.toArray.slice(0, numFeatures)
val localCoefficients = coefficients
val localGradientSumArray = gradientSumArray

val margin = {
Expand Down