[SPARK-26713][CORE][followup] revert the partial fix in ShuffleBlockFetcherIterator #25049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #107225 has finished for PR 25049 at commit
|
Contributor
|
I am fine with this revert change. Thanks wenchen for bringing it up.
I'd rather call |
Contributor
Author
|
yea |
Member
|
Merged to master. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 18, 2019
…ask is finished ### What changes were proposed in this pull request? Manually release stdin writer and stderr reader thread when task is finished. This is the backport of #23638 including #25049. ### Why are the changes needed? This is a bug fix. PipedRDD's IO threads may hang even the corresponding task is already finished. Without this fix, it would leak resource(memory specially). ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Add new test Closes #25825 from advancedxy/SPARK-26713_for_2.4. Authored-by: Xianjin YE <advancedxy@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
rshkv
pushed a commit
to palantir/spark
that referenced
this pull request
Mar 12, 2021
…ask is finished ### What changes were proposed in this pull request? Manually release stdin writer and stderr reader thread when task is finished. This is the backport of apache#23638 including apache#25049. ### Why are the changes needed? This is a bug fix. PipedRDD's IO threads may hang even the corresponding task is already finished. Without this fix, it would leak resource(memory specially). ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Add new test Closes apache#25825 from advancedxy/SPARK-26713_for_2.4. Authored-by: Xianjin YE <advancedxy@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
rshkv
pushed a commit
to palantir/spark
that referenced
this pull request
Mar 15, 2021
…ask is finished ### What changes were proposed in this pull request? Manually release stdin writer and stderr reader thread when task is finished. This is the backport of apache#23638 including apache#25049. ### Why are the changes needed? This is a bug fix. PipedRDD's IO threads may hang even the corresponding task is already finished. Without this fix, it would leak resource(memory specially). ### Does this PR introduce any user-facing change? No. ### How was this patch tested? Add new test Closes apache#25825 from advancedxy/SPARK-26713_for_2.4. Authored-by: Xianjin YE <advancedxy@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR reverts the partial bug fix in
ShuffleBlockFetcherIteratorwhich was introduced by #23638 .The reasons:
PipelinedRDDin [SPARK-26713][CORE] Interrupt pipe IO threads in PipedRDD when task is finished #23638 , the original problem was resolved.We should fix the potential bug completely later.
How was this patch tested?
existing tests