[SPARK-28199][SS][FOLLOWUP] Remove unnecessary annotations for private API #25200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc. @zsxwing |
|
Test build #107901 has finished for PR 25200 at commit
|
dongjoon-hyun
approved these changes
Jul 19, 2019
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Merged to master.
Thank you, @HeartSaVioR .
Member
|
LGTM. Thanks for the quick PR |
Contributor
Author
|
Thanks all for quick reviewing and merging! |
yiheng
pushed a commit
to yiheng/spark
that referenced
this pull request
Jul 24, 2019
…e API ## What changes were proposed in this pull request? SPARK-28199 (apache#24996) hid implementations of Triggers into `private[sql]` and encourage end users to use `Trigger.xxx` methods instead. As I got some post review comment on apache@7548a88#r34366934 we could remove annotations which are meant to be used with public API. ## How was this patch tested? N/A Closes apache#25200 from HeartSaVioR/SPARK-28199-FOLLOWUP. Authored-by: Jungtaek Lim (HeartSaVioR) <kabhwan@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SPARK-28199 (#24996) hid implementations of Triggers into
private[sql]and encourage end users to useTrigger.xxxmethods instead.As I got some post review comment on 7548a88#r34366934 we could remove annotations which are meant to be used with public API.
How was this patch tested?
N/A