[SPARK-28586][INFRA] Make merge-spark-pr script compatible with Python 3 #25322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We still need to keep the Python2 support? |
Member
Author
|
Yea, it's deprecated but not removed out yet. |
Member
Author
|
Let me cc Spark committers to inform although it might be a bit of noise .. because I know it's annoying to use this script with Python 2 in Mac due to some pre-installed lib issues. After this PR, we can now use Python 3 for this script. cc @apache/spark-committers. |
Member
|
Nice, @HyukjinKwon ! |
HyukjinKwon
force-pushed
the
merge-script
branch
from
0d0fdc9 to
9e139db
Compare
HyukjinKwon
force-pushed
the
merge-script
branch
from
ae450de to
c204608
Compare
HyukjinKwon
force-pushed
the
merge-script
branch
from
c204608 to
11c3c7f
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Test build #108506 has finished for PR 25322 at commit
|
srowen
approved these changes
Aug 1, 2019
dongjoon-hyun
approved these changes
Aug 1, 2019
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Merged to master.
Thank you so much, @HyukjinKwon , @maropu , @srowen !
Member
|
Great! thanks @HyukjinKwon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to make
merge_spark_pr.pyscript Python 3 compatible.How was this patch tested?
Manually tested against my forked remote with the PR and JIRA below:
#25321
#25286
https://issues.apache.org/jira/browse/SPARK-28153