-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-28957][SQL] Copy any "spark.hive.foo=bar" spark properties into hadoop conf as "hive.foo=bar" #25661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #110036 has finished for PR 25661 at commit
|
|
Test build #110038 has finished for PR 25661 at commit
|
|
Jenkins retest this please. |
|
Test build #110078 has finished for PR 25661 at commit
|
felixcheung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably ok... I was a bit worry that existing app having spark.hive.* might now break, but probably low chance that is happening?
|
Test build #110086 has finished for PR 25661 at commit
|
|
@cloud-fan What do you think ? |
|
I like this proposal. It's much better than looking at all hive configs and re-implementing it in Spark. (see how @WeichenXu123 can you resolve the conflicts? |
|
Can we also update |
|
Test build #111280 has finished for PR 25661 at commit
|
|
Test build #111323 has finished for PR 25661 at commit
|
|
thanks, merging to master! |
| @@ -79,8 +79,10 @@ private[spark] class SparkHadoopUtil extends Logging { | |||
| * Appends S3-specific, spark.hadoop.*, and spark.buffer.size configurations to a Hadoop | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit. This function description seems to become behind, but, PR looks good.
Thanks!
What changes were proposed in this pull request?
Copy any "spark.hive.foo=bar" spark properties into hadoop conf as "hive.foo=bar"
Why are the changes needed?
Providing spark side config entry for hive configurations.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT.