-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-29101][SQL] Fix count API for csv file when DROPMALFORMED mode is selected #25820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ok to test |
|
Thank you for making a PR, @sandeep-katta . |
|
cc @HyukjinKwon |
|
BTW, @sandeep-katta . |
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/UnivocityParser.scala
Show resolved
Hide resolved
|
Test build #110831 has finished for PR 25820 at commit
|
|
Test build #110871 has finished for PR 25820 at commit
|
|
Test build #110870 has finished for PR 25820 at commit
|
|
Test build #110867 has finished for PR 25820 at commit
|
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/UnivocityParser.scala
Outdated
Show resolved
Hide resolved
HyukjinKwon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good otherwise
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
Outdated
Show resolved
Hide resolved
|
Test build #110892 has finished for PR 25820 at commit
|
|
Test build #110898 has finished for PR 25820 at commit
|
|
Merged to master. |
|
Thank you, @sandeep-katta and @HyukjinKwon . |
|
I didn't check branch-2.4. @sandeep-katta can you check and open a bacport PR? I will review there. |
What changes were proposed in this pull request?
#DataSet
fruit,color,price,quantity
apple,red,1,3
banana,yellow,2,4
orange,orange,3,5
xxx
This PR aims to fix the below
This is caused by the issue SPARK-24645.
SPARK-24645 issue can also be solved by SPARK-25387
Why are the changes needed?
SPARK-24645 caused this regression, so reverted the code as it can also be solved by SPARK-25387
Does this PR introduce any user-facing change?
No,
How was this patch tested?
Added UT, and also tested the bug SPARK-24645
SPARK-24645 regression
