[SPARK-29229][SQL] Change the additional remote repository in IsolatedClientLoader to google minor #25915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #111284 has finished for PR 25915 at commit
|
srowen
reviewed
Sep 24, 2019
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
This also looks good to me pending tests.
Contributor
|
thanks, merging to master！ |
Member
|
Thank you, all!
|
Contributor
|
+1, feel free to backport, or I can do it tomorrow. |
Member
|
Thank you. I'll do that~ |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 24, 2019
…dClientLoader to google minor ### What changes were proposed in this pull request? Change the remote repo used in IsolatedClientLoader from datanucleus to google mirror. ### Why are the changes needed? We need to connect the Maven repositories in IsolatedClientLoader for downloading Hive jars. The repository currently used is "http://www.datanucleus.org/downloads/maven2", which is [no longer maintained](http://www.datanucleus.org:15080/downloads/maven2/README.txt). This will cause downloading failure and make hive test cases flaky while Jenkins host is blocked by maven central repo. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Existing UT. Closes #25915 from xuanyuanking/SPARK-29229. Authored-by: Yuanjian Li <xyliyuanjian@gmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit b3e9be4) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Member
Author
|
Thanks for reviewing. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change the remote repo used in IsolatedClientLoader from datanucleus to google mirror.
Why are the changes needed?
We need to connect the Maven repositories in IsolatedClientLoader for downloading Hive jars. The repository currently used is "http://www.datanucleus.org/downloads/maven2", which is no longer maintained. This will cause downloading failure and make hive test cases flaky while Jenkins host is blocked by maven central repo.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UT.