[SPARK-29168][WebUI][FOLLOW-UP] Use a dark colors on selected Executor removed on timeline view #25921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomokoKomiyama
changed the title
Member
|
ok to test. |
sarutak
requested changes
Sep 25, 2019
Contributor
Author
|
cc. @dongjoon-hyun |
|
Test build #111318 has finished for PR 25921 at commit
|
Member
|
retest this please. |
|
Test build #111326 has finished for PR 25921 at commit
|
sarutak
approved these changes
Sep 25, 2019
dongjoon-hyun
approved these changes
Sep 25, 2019
srowen
approved these changes
Sep 25, 2019
dongjoon-hyun
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Changed Executor color settings in timeline-view.cssWhy are the changes needed?
In WebUI, color of executor changes to dark blue when you click it. It might be confused user because of the color.[ Before ]
[ After ]
Does this PR introduce any user-facing change?
Yes.How was this patch tested?
Manually test.