Skip to content

Conversation

@cloud-fan
Copy link
Contributor

What changes were proposed in this pull request?

add document to address #26612 (comment)

Why are the changes needed?

help people understand how to use --CONFIG_DIM

Does this PR introduce any user-facing change?

no

How was this patch tested?

N/A

@cloud-fan
Copy link
Contributor Author

cc @maropu @HyukjinKwon

queries: Seq[String],
testCase: TestCase,
configSet: Option[Seq[(String, String)]]): Unit = {
configSet: Seq[(String, String)]): Unit = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not very related but to simplify things.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for this simplication.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@maropu maropu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@maropu maropu closed this in bd9ce83 Nov 25, 2019
@maropu
Copy link
Member

maropu commented Nov 25, 2019

Merged to master.
(Sorry, but I made a mistake to merge this before passing the tests. If any issue happens, I'll do somethig then.)

@SparkQA
Copy link

SparkQA commented Nov 25, 2019

Test build #114392 has finished for PR 26661 at commit a1125b5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu
Copy link
Member

maropu commented Nov 25, 2019

(I got relieved...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants