-
Notifications
You must be signed in to change notification settings - Fork 29.1k
[SPARK-29975][SQL][followup] document --CONFIG_DIM #26661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| queries: Seq[String], | ||
| testCase: TestCase, | ||
| configSet: Option[Seq[(String, String)]]): Unit = { | ||
| configSet: Seq[(String, String)]): Unit = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not very related but to simplify things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for this simplication.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
maropu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
|
Merged to master. |
|
Test build #114392 has finished for PR 26661 at commit
|
|
(I got relieved...) |
What changes were proposed in this pull request?
add document to address #26612 (comment)
Why are the changes needed?
help people understand how to use --CONFIG_DIM
Does this PR introduce any user-facing change?
no
How was this patch tested?
N/A