[MINOR][SQL] Rename config name to spark.sql.analyzer.failAmbiguousSelfJoin.enabled #26694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @gatorsmile |
srowen
reviewed
Nov 27, 2019
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
Seems fine if this was never released yet as a config that people use already.
Contributor
Author
|
yea this config is new in 3.0 |
dongjoon-hyun
changed the title
|
|
||
| val FAIL_AMBIGUOUS_SELF_JOIN = | ||
| buildConf("spark.sql.analyzer.failAmbiguousSelfJoin") | ||
| buildConf("spark.sql.analyzer.failAmbiguousSelfJoin.enabled") |
Member
There was a problem hiding this comment.
Could you update docs/sql-migration-guide.md, too? There is an instance referring this.
To restore the behavior before Spark 3.0, you can set
spark.sql.analyzer.failAmbiguousSelfJointofalse.
| .booleanConf | ||
| .createWithDefault(true) | ||
|
|
||
| val FAIL_AMBIGUOUS_SELF_JOIN = |
Member
There was a problem hiding this comment.
Maybe, FAIL_AMBIGUOUS_SELF_JOIN -> FAIL_AMBIGUOUS_SELF_JOIN_ENABLED?
It seems that we are using _ENABLED pattern for .enabled conf sometime.
dongjoon-hyun
changed the title
|
Test build #114539 has finished for PR 26694 at commit
|
|
Test build #114715 has finished for PR 26694 at commit
|
Contributor
Author
|
merging to master! |
Member
|
Thank you for update. |
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Dec 6, 2019
…lfJoin.enabled ### What changes were proposed in this pull request? add `.enabled` postfix to `spark.sql.analyzer.failAmbiguousSelfJoin`. ### Why are the changes needed? to follow the existing naming style ### Does this PR introduce any user-facing change? no ### How was this patch tested? not needed Closes apache#26694 from cloud-fan/conf. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
rshkv
pushed a commit
to palantir/spark
that referenced
this pull request
Jan 28, 2021
…lfJoin.enabled add `.enabled` postfix to `spark.sql.analyzer.failAmbiguousSelfJoin`. to follow the existing naming style no not needed Closes apache#26694 from cloud-fan/conf. Authored-by: Wenchen Fan <wenchen@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add
.enabledpostfix tospark.sql.analyzer.failAmbiguousSelfJoin.Why are the changes needed?
to follow the existing naming style
Does this PR introduce any user-facing change?
no
How was this patch tested?
not needed