Skip to content

[SPARK-30312][SQL][FOLLOWUP] Use inequality check instead to be robust #27175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
viirya wants to merge 1 commit into from
Closed

[SPARK-30312][SQL][FOLLOWUP] Use inequality check instead to be robust #27175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2052,7 +2052,7 @@ abstract class DDLSuite extends QueryTest with SQLTestUtils {

val fileStatus2 = fs.getFileStatus(tablePath)
if (ignore) {
assert(fileStatus2.getPermission().toString() == "rwxr-xr-x")
assert(fileStatus2.getPermission().toString() != "rwxrwxrwx")
Copy link
Member Author

@viirya viirya Jan 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a loose condition. I think it is rarely to have default file permission as rwxrwxrwx. Another option is not to check permission when ignore is true.

} else {
assert(fileStatus2.getPermission().toString() == "rwxrwxrwx")
}
Expand Down