[SPARK-30312][SQL][FOLLOWUP] Rename conf by adding .enabled
#27210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
HyukjinKwon
approved these changes
Jan 15, 2020
|
Test build #116750 has finished for PR 27210 at commit
|
Member
|
retest this please |
|
Test build #116773 has finished for PR 27210 at commit
|
Member
Author
|
@dongjoon-hyun Do you have some comment on this change? If not, I will merge this. |
Member
Author
|
@dongjoon-hyun I found you cut v2.4.5-rc1 already. If this goes into master/2.4, then you need to cut rc2? |
dongjoon-hyun
approved these changes
Jan 16, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @viirya and @HyukjinKwon .
Merged to master/2.4.
Yes. I'm planning to cut RC2 on next Monday.
dongjoon-hyun
changed the title
.enabled
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jan 16, 2020
Based on the [comment](#26956 (comment)), this patch changes the SQL config name from `spark.sql.truncateTable.ignorePermissionAcl` to `spark.sql.truncateTable.ignorePermissionAcl.enabled`. Make this config consistent other SQL configs. No. Unit test. Closes #27210 from viirya/truncate-table-permission-followup. Authored-by: Liang-Chi Hsieh <viirya@gmail.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit be4d825) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Based on the comment, this patch changes the SQL config name from
spark.sql.truncateTable.ignorePermissionAcltospark.sql.truncateTable.ignorePermissionAcl.enabled.Why are the changes needed?
Make this config consistent other SQL configs.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test.