Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jan 17, 2020

What changes were proposed in this pull request?

This is a followup of #26956 to add a migration document for 2.4.5.

Why are the changes needed?

New legacy configuration will restore the previous behavior safely.

Does this PR introduce any user-facing change?

This PR updates the doc.

screenshot

How was this patch tested?

Build the document and see the change manually.

@dongjoon-hyun
Copy link
Member Author

cc @viirya and @gatorsmile

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-30312][SQL][DOCS][FOLLOWUP] Add a migration guide [SPARK-30312][DOCS][FOLLOWUP] Add a migration guide Jan 17, 2020
@dongjoon-hyun
Copy link
Member Author

Hi, @viirya . Could you review this? After this, I want to add more on this 2.4.4 -> 2.4.5 and add 2.4.3 -> 2.4.4, too.

@viirya
Copy link
Member

viirya commented Jan 17, 2020 via email

@SparkQA
Copy link

SparkQA commented Jan 17, 2020

Test build #116963 has finished for PR 27269 at commit 6b64d57.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member

viirya commented Jan 17, 2020

retest this please

@viirya
Copy link
Member

viirya commented Jan 17, 2020

Will we have 2.4.3 -> 2.4.4 for the same config, right?

Do we need 2.4.3 -> 2.4.4? I think this is added since 2.4.5, no?

@SparkQA
Copy link

SparkQA commented Jan 17, 2020

Test build #116965 has finished for PR 27269 at commit 6b64d57.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

The 2.4.3 -> 2.4.4 migration guide is not for this conf. That's @gatorsmile 's another request on MsSQLServer JDBC Dialect conf. To avoid conflicts between my PRs, I've been waiting for this. :)

Thank you. Merged to master/2.4.

dongjoon-hyun added a commit that referenced this pull request Jan 17, 2020
This is a followup of #26956 to add a migration document for 2.4.5.

New legacy configuration will restore the previous behavior safely.

This PR updates the doc.

<img width="763" alt="screenshot" src="https://user-images.githubusercontent.com/9700541/72639939-9da5a400-391b-11ea-87b1-14bca15db5a6.png">

Build the document and see the change manually.

Closes #27269 from dongjoon-hyun/SPARK-30312.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit fdbded3)
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants