-
Notifications
You must be signed in to change notification settings - Fork 29k
fixed dynamic pagerank vertex update computation #2738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There seems to be a typo here when comparing to static version or to the usual pagerank algorithm. if we take a node in the graph, on each iteration, we add a random jump to any node in the graph with equal probability of resetProb/N. Then summing for all nodes in the graph yields the resetProb on line 155, which has nothing to do with the pagerank value for last iteration.
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
@planvin I think this is the intended behavior, because |
|
ok to test |
|
QA tests have started for PR 2738 at commit
|
|
Test FAILed. |
As mentioned in #1000, but we still need to add the random jump
|
QA tests have started for PR 2738 at commit
|
|
QA tests have finished for PR 2738 at commit
|
|
Test FAILed. |
|
QA tests have finished for PR 2738 at commit
|
|
Test FAILed. |
|
I am clearly missing something here. Sorry for that. I am closing the PR. |
There seems to be a typo here when comparing to static version or to the usual pagerank algorithm. if we take a node in the graph, on each iteration, we add a random jump to any node in the graph with equal probability of resetProb/N. Then summing for all nodes in the graph yields the resetProb on line 155, which has nothing to do with the pagerank value for last iteration.