Skip to content

Conversation

@plaanv
Copy link

@plaanv plaanv commented Oct 9, 2014

There seems to be a typo here when comparing to static version or to the usual pagerank algorithm. if we take a node in the graph, on each iteration, we add a random jump to any node in the graph with equal probability of resetProb/N. Then summing for all nodes in the graph yields the resetProb on line 155, which has nothing to do with the pagerank value for last iteration.

There seems to be a typo here when comparing to static version or to the usual pagerank algorithm. if we take a node in the graph, on each iteration, we add a random jump to any node in the graph with equal probability of resetProb/N. Then summing for all nodes in the graph yields the resetProb on line 155, which has nothing to do with the pagerank value for last iteration.
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

1 similar comment
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@ankurdave
Copy link
Contributor

@planvin I think this is the intended behavior, because msgSum is a delta, not a new PageRank value. Therefore it needs to be added to the previous rank. This has confused other people in the past: #2100 (comment)

@ankurdave
Copy link
Contributor

ok to test

@SparkQA
Copy link

SparkQA commented Oct 9, 2014

QA tests have started for PR 2738 at commit a582d1e.

  • This patch merges cleanly.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21552/Test FAILed.

As mentioned in #1000, but we still need to add the random jump
@plaanv
Copy link
Author

plaanv commented Oct 9, 2014

commited another attempt, sorry I did not see about the delta graph in #2100 (and not #1000 as I wrote in the commit description)

@SparkQA
Copy link

SparkQA commented Oct 9, 2014

QA tests have started for PR 2738 at commit 7305560.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Oct 9, 2014

QA tests have finished for PR 2738 at commit a582d1e.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21553/Test FAILed.

@SparkQA
Copy link

SparkQA commented Oct 9, 2014

QA tests have finished for PR 2738 at commit 7305560.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21555/Test FAILed.

@plaanv
Copy link
Author

plaanv commented Oct 10, 2014

I am clearly missing something here. Sorry for that. I am closing the PR.

@plaanv plaanv closed this Oct 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants