Revert "[SPARK-30808][SQL] Enable Java 8 time API in Thrift server"#27733
Closed
yaooqinn wants to merge 2 commits intoapache:masterfrom
yaooqinn:SPARK-30808
Closed
Revert "[SPARK-30808][SQL] Enable Java 8 time API in Thrift server"#27733yaooqinn wants to merge 2 commits intoapache:masterfrom yaooqinn:SPARK-30808
yaooqinn wants to merge 2 commits intoapache:masterfrom
yaooqinn:SPARK-30808
Conversation
This reverts commit afaeb29.
Member
Author
|
cc @cloud-fan and @MaxGekk the case passed both |
cloud-fan
reviewed
Feb 28, 2020
| localSparkSession.conf.set(SQLConf.ANSI_ENABLED.key, true) | ||
| case _ => | ||
| } | ||
| localSparkSession.conf.set(SQLConf.DATETIME_JAVA8API_ENABLED.key, true) |
Contributor
|
Test build #119083 has finished for PR 27733 at commit
|
|
Test build #119086 has finished for PR 27733 at commit
|
Contributor
|
retest this please |
|
Test build #119092 has finished for PR 27733 at commit
|
Contributor
|
thanks, merging to master/3.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Mar 3, 2020
This reverts commit afaeb29. ### What changes were proposed in this pull request? Based on the result and comment from #27552 (comment) In the hive module, server-side provides datetime values simply use `value.toSting`, and the client-side regenerates the results back in `HiveBaseResultSet` with `java.sql.Date(Timestamp).valueOf`. there will be inconsistency between client and server if we use java8 APIs ### Why are the changes needed? the change is still unclear enough ### Does this PR introduce any user-facing change? no ### How was this patch tested? Nah Closes #27733 from yaooqinn/SPARK-30808. Authored-by: Kent Yao <yaooqinn@hotmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 1fac06c) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
This reverts commit afaeb29. ### What changes were proposed in this pull request? Based on the result and comment from apache#27552 (comment) In the hive module, server-side provides datetime values simply use `value.toSting`, and the client-side regenerates the results back in `HiveBaseResultSet` with `java.sql.Date(Timestamp).valueOf`. there will be inconsistency between client and server if we use java8 APIs ### Why are the changes needed? the change is still unclear enough ### Does this PR introduce any user-facing change? no ### How was this patch tested? Nah Closes apache#27733 from yaooqinn/SPARK-30808. Authored-by: Kent Yao <yaooqinn@hotmail.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit afaeb29.
What changes were proposed in this pull request?
Based on the result and comment from #27552 (comment)
In the hive module, server-side provides datetime values simply use
value.toSting, and the client-side regenerates the results back inHiveBaseResultSetwithjava.sql.Date(Timestamp).valueOf.there will be inconsistency between client and server if we use java8 APIs
Why are the changes needed?
the change is still unclear enough
Does this PR introduce any user-facing change?
no
How was this patch tested?
Nah