Skip to content

[SPARK-31565][WEBUI][FOLLOWUP] Add font color setting of DAG-viz for query plan. #28355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sarutak wants to merge 1 commit into from
Closed

[SPARK-31565][WEBUI][FOLLOWUP] Add font color setting of DAG-viz for query plan. #28355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sql/core/src/main/resources/org/apache/spark/sql/execution/ui/static/spark-sql-viz.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@
font-weight: bold;
}

#plan-viz-graph svg text {
Copy link
Member

@dongjoon-hyun dongjoon-hyun Apr 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, we handled all .label. Now, this PR is about text.
If we start to consider text, are you sure that this is the last text?

Copy link
Member Author

@sarutak sarutak Apr 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to consider three part of DAG-viz. Stages, RDDs and query plans.

In the previous PR, I changed the color of .label for stages and RDDs. Both are covered here.
I also changed color of .label for query plans here.

About text, for stages and RDDs, it's already covered here.
So I think the last one is for query plans. It's covered by this PR.

Copy link
Member

@dongjoon-hyun dongjoon-hyun Apr 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the confirmation! Now, it's clear to me.

fill: #333;
}

#plan-viz-graph svg path {
stroke: #444;
stroke-width: 1.5px;
Expand Down