Skip to content

Conversation

@beliefer
Copy link
Contributor

@beliefer beliefer commented Feb 7, 2021

What changes were proposed in this pull request?

The current implement of some DDL not unify the output and not pass the output properly to physical command.
Such as: The output attributes of ShowViews does't pass to ShowViewsCommand properly.

As the query plan, this PR pass the output attributes from ShowViews to ShowViewsCommand.

Why are the changes needed?

This PR pass the output attributes could keep the expr ID unchanged, so that avoid bugs when we apply more operators above the command output dataframe.

Does this PR introduce any user-facing change?

'No'.

How was this patch tested?

Jenkins test.

@github-actions github-actions bot added the SQL label Feb 7, 2021
@SparkQA
Copy link

SparkQA commented Feb 7, 2021

Test build #134989 has finished for PR 31508 at commit 0691993.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Feb 8, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39578/

@SparkQA
Copy link

SparkQA commented Feb 8, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39578/

@SparkQA
Copy link

SparkQA commented Feb 8, 2021

Test build #134995 has finished for PR 31508 at commit d964a05.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@beliefer
Copy link
Contributor Author

beliefer commented Feb 8, 2021

retest this please

@SparkQA
Copy link

SparkQA commented Feb 8, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39595/

@SparkQA
Copy link

SparkQA commented Feb 8, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39595/

@SparkQA
Copy link

SparkQA commented Feb 8, 2021

Test build #135012 has finished for PR 31508 at commit d964a05.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@beliefer
Copy link
Contributor Author

beliefer commented Feb 9, 2021

cc @cloud-fan

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@cloud-fan cloud-fan closed this in c925e4d Feb 18, 2021
@beliefer
Copy link
Contributor Author

@cloud-fan Thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants