[SPARK-34394][SQL] Unify output of SHOW FUNCTIONS and pass output attributes properly #31519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #135010 has finished for PR 31519 at commit
|
Contributor
Author
|
cc @cloud-fan |
cloud-fan
approved these changes
Feb 18, 2021
Contributor
|
thanks, merging to master! |
Contributor
Author
|
@cloud-fan Thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The current implement of some DDL not unify the output and not pass the output properly to physical command.
Such as: The output attributes of
ShowFunctionsdoes't pass toShowFunctionsCommandproperly.As the query plan, this PR pass the output attributes from
ShowFunctionstoShowFunctionsCommand.Why are the changes needed?
This PR pass the output attributes could keep the expr ID unchanged, so that avoid bugs when we apply more operators above the command output dataframe.
Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
Jenkins test.