Skip to content

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Feb 8, 2021

What changes were proposed in this pull request?

This PR is a followup of #31245:

[error] /home/runner/work/spark/spark/sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala:112:53: value deep is not a member of Array[String]
[error]         assert(sql("show tables").schema.fieldNames.deep ==
[error]                                                     ^
[error] /home/runner/work/spark/spark/sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala:115:72: value deep is not a member of Array[String]
[error]         assert(sql("show table extended like 'tbl'").schema.fieldNames.deep ==
[error]                                                                        ^
[error] /home/runner/work/spark/spark/sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala:121:55: value deep is not a member of Array[String]
[error]           assert(sql("show tables").schema.fieldNames.deep ==
[error]                                                       ^
[error] /home/runner/work/spark/spark/sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/ShowTablesSuite.scala:124:74: value deep is not a member of Array[String]
[error]           assert(sql("show table extended like 'tbl'").schema.fieldNames.deep ==
[error]                                                                          ^

It broke Scala 2.13 build. This PR works around by using ScalaTests' === that can compare Arrays safely.

Why are the changes needed?

To fix the build.

Does this PR introduce any user-facing change?

No, dev-only.

How was this patch tested?

CI in this PR should test it out.

@HyukjinKwon HyukjinKwon changed the title [SPARK-34157][BUILD][FOLLOW-UP] Fix Scala 2.13 compliation error via using deep [SPARK-34157][BUILD][FOLLOW-UP] Fix Scala 2.13 compilation error via using Array.deep Feb 8, 2021
Copy link
Contributor

@cloud-fan cloud-fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing!

@github-actions github-actions bot added the SQL label Feb 8, 2021
@HyukjinKwon
Copy link
Member Author

Okay, Scala 2.13 build passes. I manually tested that it fixes the tests too locally. Let me merge this in to unblock other PRs.

@SparkQA
Copy link

SparkQA commented Feb 8, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39613/

@SparkQA
Copy link

SparkQA commented Feb 8, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39613/

@beliefer
Copy link
Contributor

beliefer commented Feb 9, 2021

@HyukjinKwon Thanks for your fix!

@HyukjinKwon HyukjinKwon deleted the SPARK-34157 branch January 4, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants