Skip to content

[SPARK-34445][SQL][DOCS] Make spark.sql.legacy.replaceDatabricksSparkAvro.enabled as non-internal #31571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxGekk wants to merge 1 commit into from
Closed

[SPARK-34445][SQL][DOCS] Make spark.sql.legacy.replaceDatabricksSparkAvro.enabled as non-internal #31571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2505,7 +2505,6 @@ object SQLConf {

val LEGACY_REPLACE_DATABRICKS_SPARK_AVRO_ENABLED =
buildConf("spark.sql.legacy.replaceDatabricksSparkAvro.enabled")
Copy link
Member

@HyukjinKwon HyukjinKwon Feb 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gengliangwang do we need this conf? We do the same thing in com.databricks.spark.csv already by default internally. We could just make it exposed and deprecate this config.

Copy link
Member

@HyukjinKwon HyukjinKwon Feb 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this way, I think it will address most of concerns raised.

Copy link
Member

@HyukjinKwon HyukjinKwon Feb 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And then we could remove both com.databricks.spark.csv and com.databricks.spark.avro fallbacks together in the future, of course (Spark 4.0?). I don't think it makes sense to keep both mapping forever.

Copy link
Contributor

@cloud-fan cloud-fan Feb 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's deprecate it and then remove it in later versions. It's OK if a deprecated internal config is mentioned in public docs for migration purpose.

Copy link
Member Author

@MaxGekk MaxGekk Feb 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the PR #31578 to deprecate the config.

Copy link
Member

@dongjoon-hyun dongjoon-hyun Feb 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you all!

.internal()
.doc("If it is set to true, the data source provider com.databricks.spark.avro is mapped " +
"to the built-in but external Avro data source module for backward compatibility.")
.version("2.4.0")
Expand Down