-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-34576][SQL] Fix drop/add columns to a dataset of DESCRIBE COLUMN
#31696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #135622 has started for PR 31696 at commit |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
| ResolvedViewIdentifier(ident), column: UnresolvedAttribute, isExtended, _) => | ||
| // For views, the column will not be resolved by `ResolveReferences` because | ||
| // `ResolvedView` stores only the identifier. | ||
| DescribeColumnCommand(ident.asTableIdentifier, column.nameParts, isExtended) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we pass the output to the v1 command as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we pass the output to the v1 command as well?
You mean unify V2 and v1 DESC command's output? I think v2's DESC TABLE need to do this too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, you can fix it here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, you can fix it here as well.
Done
|
Test build #135632 has finished for PR 31696 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
retest this please |
|
Test build #135660 has finished for PR 31696 at commit
|
|
thanks, merging to master! |
|
@AngersZhuuuu can you open a backport PR for 3.1? |
sure |
MaxGekk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this PR be ported to 3.0?
|
#31676 doesn't go to 3.0 either. Shall we backport both? |
What changes were proposed in this pull request?
In the PR, I propose to generate "stable" output attributes per the logical node of the DESCRIBE COLUMN command.
Why are the changes needed?
This fixes the issue demonstrated by the example:
Does this PR introduce any user-facing change?
After this change user
drop()/add()works well.How was this patch tested?
Added UT