-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-33482][SPARK-34756][SQL] Fix FileScan equality check #31848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
peter-toth
wants to merge
10
commits into
apache:master
from
peter-toth:SPARK-34756-fix-filescan-equality-check
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e1a9722
[SPARK-34756][SQL] Fix FileScan equality check
peter-toth f65ebe3
normalize filters in `FileScan.equals()`
peter-toth 776828e
add attribute name normalization
peter-toth 6709185
add e3e test
peter-toth b631350
Merge commit '2e836cdb598255d6b43b386e98fcb79b70338e69' into SPARK-34…
peter-toth 9711da0
add FileScanSuite and AvroScanSuite
peter-toth d782723
compact test code
peter-toth 241e6e4
Merge commit '7953fcdb56abd2e574ea7fdfed925fe06dffdec0' into SPARK-34…
peter-toth 30d2d8b
remove the case sensitivity handling
peter-toth 0d38ac2
fix naming
peter-toth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
30 changes: 30 additions & 0 deletions
30
external/avro/src/test/scala/org/apache/spark/sql/avro/AvroScanSuite.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.sql.avro | ||
|
|
||
| import org.apache.spark.sql.FileScanSuiteBase | ||
| import org.apache.spark.sql.v2.avro.AvroScan | ||
|
|
||
| class AvroScanSuite extends FileScanSuiteBase { | ||
| val scanBuilders = Seq[(String, ScanBuilder, Seq[String])]( | ||
| ("AvroScan", | ||
| (s, fi, ds, rds, rps, f, o, pf, df) => AvroScan(s, fi, ds, rds, rps, o, f, pf, df), | ||
| Seq.empty)) | ||
|
|
||
| run(scanBuilders) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall I update
hashCode()as well? Looks like we can easily come up with a better one...Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we do that separately because it's irrelevant to the correctness issue?
In general, we expect a performance improvement with that, don't we?
Apache Spark doesn't allow to backport performance improvement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please file a new JIRA and go for it, @peter-toth ! :)