Skip to content

[SPARK-31225][SQL][2.4] Override sql method of OuterReference #32256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yaooqinn wants to merge 3 commits into from
Closed

[SPARK-31225][SQL][2.4] Override sql method of OuterReference #32256

yaooqinn wants to merge 3 commits into from

Conversation

@yaooqinn
Copy link
Member

@yaooqinn yaooqinn commented Apr 20, 2021

What changes were proposed in this pull request?

Per #32179 (comment) 's request to backport SPARK-31225 to branch 2.4

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

@yaooqinn
Copy link
Member Author

yaooqinn commented Apr 20, 2021

cc @cloud-fan @viirya thanks

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Apr 20, 2021

Once Jenkins build passes, it should be good to go.

@SparkQA
Copy link

SparkQA commented Apr 20, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42216/

@SparkQA
Copy link

SparkQA commented Apr 20, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42216/

cloud-fan
cloud-fan approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@cloud-fan cloud-fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass

@SparkQA
Copy link

SparkQA commented Apr 20, 2021

Test build #137689 has finished for PR 32256 at commit d887e74.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member

viirya commented Apr 20, 2021

Can you fix the error message?

viirya
viirya approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. we just need to update the error message in the failed test.

@SparkQA
Copy link

SparkQA commented Apr 20, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42225/

@SparkQA
Copy link

SparkQA commented Apr 20, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42225/

@SparkQA
Copy link

SparkQA commented Apr 20, 2021

Test build #137698 has finished for PR 32256 at commit 5e945b4.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member

viirya commented Apr 20, 2021

Seems there is still other error?

@SparkQA
Copy link

SparkQA commented Apr 21, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42240/

@SparkQA
Copy link

SparkQA commented Apr 21, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42240/

@SparkQA
Copy link

SparkQA commented Apr 21, 2021

Test build #137712 has finished for PR 32256 at commit a4681c3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

cloud-fan commented Apr 21, 2021

thanks, merging to 2.4!

@viirya
Copy link
Member

viirya commented Apr 21, 2021

Thanks! Merging to 2.4.

cloud-fan pushed a commit that referenced this pull request Apr 21, 2021
@yaooqinn @cloud-fan
[SPARK-31225][SQL][2.4] Override sql method of OuterReference
1630d64 
### What changes were proposed in this pull request?

Per #32179 (comment) 's request to backport SPARK-31225 to branch 2.4

### Why are the changes needed?

### Does this PR introduce _any_ user-facing change?

### How was this patch tested?

Closes #32256 from yaooqinn/SPARK-31225.

Authored-by: Kent Yao <yao@apache.org>
Signed-off-by: Wenchen Fan <wenchen@databricks.com>
@cloud-fan cloud-fan closed this Apr 21, 2021
@yaooqinn yaooqinn deleted the SPARK-31225 branch April 21, 2021 07:35
@viirya viirya mentioned this pull request Apr 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@viirya viirya viirya approved these changes

@cloud-fan cloud-fan cloud-fan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yaooqinn @HyukjinKwon @SparkQA @viirya @cloud-fan