Skip to content

[SPARK-35142][PYTHON][ML][3.0] Fix incorrect return type for rawPredictionUDF in OneVsRestModel #32275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
harupy wants to merge 1 commit into from
Closed

[SPARK-35142][PYTHON][ML][3.0] Fix incorrect return type for rawPredictionUDF in OneVsRestModel #32275

harupy wants to merge 1 commit into from

Conversation

@harupy
Copy link
Contributor

@harupy harupy commented Apr 21, 2021 •
edited
Loading

What changes were proposed in this pull request?

This PR backports #32245.

Fixes incorrect return type for rawPredictionUDF in OneVsRestModel.

Why are the changes needed?

Bugfix

Does this PR introduce any user-facing change?

No

How was this patch tested?

Unit test.

@harupy harupy changed the title [SPARK-35142][PYTHON][ML][3.0] Fix incorrect return type for rawPredictionUDF in OneVsRestModel [SPARK-35142][PYTHON][ML][3.0] Fix incorrect return type for rawPredictionUDF in OneVsRestModel Apr 21, 2021
HyukjinKwon
HyukjinKwon approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@HyukjinKwon HyukjinKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass

@SparkQA
Copy link

SparkQA commented Apr 21, 2021

Test build #137735 has finished for PR 32275 at commit 1e84817.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 21, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42262/

Yikun
Yikun approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@Yikun Yikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and the CI failed is unrelated.

@HyukjinKwon
Copy link
Member

HyukjinKwon commented Apr 22, 2021

retest this please

@SparkQA
Copy link

SparkQA commented Apr 22, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42285/

@SparkQA
Copy link

SparkQA commented Apr 22, 2021

Test build #137758 has finished for PR 32275 at commit 1e84817.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Apr 23, 2021

Jenkins retest this please

@SparkQA
Copy link

SparkQA commented Apr 23, 2021

Test build #137870 has finished for PR 32275 at commit 1e84817.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Apr 23, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42400/

@SparkQA
Copy link

SparkQA commented Apr 23, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42400/

dongjoon-hyun
dongjoon-hyun approved these changes Apr 24, 2021
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @harupy and all.
Merged to branch-3.0.

dongjoon-hyun pushed a commit that referenced this pull request Apr 24, 2021
@harupy @dongjoon-hyun
[SPARK-35142][PYTHON][ML][3.0] Fix incorrect return type for `rawPred…
4c79e10 
…ictionUDF` in `OneVsRestModel`

### What changes were proposed in this pull request?

This PR backports #32245.

Fixes incorrect return type for `rawPredictionUDF` in `OneVsRestModel`.

### Why are the changes needed?
Bugfix

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Unit test.

Closes #32275 from harupy/backport-35142-3.0.

Authored-by: harupy <17039389+harupy@users.noreply.github.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Apr 24, 2021

I added you to the Apache Spark contributor group and SPARK-35142 is assigned to you.
Thank you for your first contribution, @harupy . Welcome!

@harupy
Copy link
Contributor Author

harupy commented Apr 25, 2021

@dongjoon-hyun Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yikun Yikun Yikun approved these changes

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@harupy @SparkQA @HyukjinKwon @srowen @dongjoon-hyun @Yikun