[SPARK-35328][Core] Use 'SPARK_DRIVER_LOG_URL_' as env prefix for getting driver log urls by default #32456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Member
|
@sharkdtu do you mind:
|
HyukjinKwon
changed the title
sharkdtu
changed the title
Contributor
Author
|
@HyukjinKwon Thanks, PR description has been updated and the test failure has been fixed. |
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
Show resolved
Hide resolved
Contributor
Author
|
@HyukjinKwon Could you review this pr, and merge it if it is ok. Thanks a lot. |
|
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable. |
|
Does anyone follow up on this pr? It's quite useful for spark on k8s. |
Member
|
I'm working on #38357, it covers this functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Currently, spark on kubernetes can't show logs url on ui. To check history logs, we usually collect pod logs to third-party logging services, which can be accessed by urls. To show log urls on ui, we can set env prefixed with 'SPARK_LOG_URL_' for executors. But for driver, there is no way to show log urls by setting env.
This pr use 'SPARK_DRIVER_LOG_URL_' as env prefix for getting driver log urls by default.
Why are the changes needed?
To show driver log urls on ui by setting env prefixed with 'SPARK_DRIVER_LOG_URL_'.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A