Skip to content

[SPARK-33743]change TimestampType match to datetime2 instead of datetime for MsSQLServerDialect #32655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luxu1-ms wants to merge 2 commits into from
Closed

[SPARK-33743]change TimestampType match to datetime2 instead of datetime for MsSQLServerDialect #32655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64626ff
change TimestampType match to datetime2 for MsSQLServerDialect
luxu1-ms Apr 6, 2021
ae35e8c
update test case for datetime2 mapping
luxu1-ms Jun 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/core/src/main/scala/org/apache/spark/sql/jdbc/MsSqlServerDialect.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ private object MsSqlServerDialect extends JdbcDialect {
}

override def getJDBCType(dt: DataType): Option[JdbcType] = dt match {
case TimestampType => Some(JdbcType("DATETIME", java.sql.Types.TIMESTAMP))
case TimestampType => Some(JdbcType("DATETIME2", java.sql.Types.TIMESTAMP))
Comment thread
luxu1-ms marked this conversation as resolved.
case StringType => Some(JdbcType("NVARCHAR(MAX)", java.sql.Types.NVARCHAR))
case BooleanType => Some(JdbcType("BIT", java.sql.Types.BIT))
case BinaryType => Some(JdbcType("VARBINARY(MAX)", java.sql.Types.VARBINARY))
Expand Down
2 changes: 1 addition & 1 deletion sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -938,7 +938,7 @@ class JDBCSuite extends QueryTest
test("MsSqlServerDialect jdbc type mapping") {
val msSqlServerDialect = JdbcDialects.get("jdbc:sqlserver")
assert(msSqlServerDialect.getJDBCType(TimestampType).map(_.databaseTypeDefinition).get ==
"DATETIME")
"DATETIME2")
assert(msSqlServerDialect.getJDBCType(StringType).map(_.databaseTypeDefinition).get ==
"NVARCHAR(MAX)")
assert(msSqlServerDialect.getJDBCType(BooleanType).map(_.databaseTypeDefinition).get ==
Expand Down