Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jun 29, 2021

What changes were proposed in this pull request?

This PR aims to enable docker_integration_tests when catalyst and sql module changes additionally.

Why are the changes needed?

Currently, catalyst and sql module changes do not trigger the JDBC integration test.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

N/A

@github-actions github-actions bot added the BUILD label Jun 29, 2021
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-35483][TESTS] Add sql dependency to docker_integration_tests [SPARK-35483][TESTS] Enable docker_integration_tests for catalyst/sql module changes too Jun 29, 2021
@dongjoon-hyun
Copy link
Member Author

Thank you, @sarutak and @HyukjinKwon .

@dongjoon-hyun
Copy link
Member Author

Merged to master.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-35483][TESTS] Enable docker_integration_tests for catalyst/sql module changes too [SPARK-35483][FOLLOWUP][TESTS] Enable docker_integration_tests for catalyst/sql module changes too Jun 29, 2021
@dongjoon-hyun dongjoon-hyun deleted the SPARK-35483 branch June 29, 2021 06:00
@dongjoon-hyun
Copy link
Member Author

Oh my bad. There is a UT for this modules.py. Let me fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants