Skip to content

Conversation

@awdavidson
Copy link
Contributor

@awdavidson awdavidson commented Feb 8, 2023

As requested by @HyukjinKwon in #38312 NB: This change needs to be backported

What changes were proposed in this pull request?

Update version set for "spark.sql.legacy.parquet.nanosAsLong" configuration in SqlConf. This update is required because the previous PR set version to 3.2.3 which has already been released. Updating to version 3.2.4 will correctly reflect when this configuration element was added

Why are the changes needed?

Correctness and to complete SPARK-40819

Does this PR introduce any user-facing change?

No, this is merely so this configuration element has the correct version

How was this patch tested?

N/A

@github-actions github-actions bot added the SQL label Feb 8, 2023
@LuciferYang
Copy link
Contributor

PR title should be [SPARK-40819][SQL][FOLLOWUP]...

And the pr title and description a little difficult to understand for me if I didn't look at the changes ...

@awdavidson awdavidson changed the title [SPARK-40819][SQL] Update version for nanos as long in SqlConf [SPARK-40819][SQL][FOLLOWUP] Update SqlConf version for nanos as long configuration Feb 8, 2023
@awdavidson awdavidson changed the title [SPARK-40819][SQL][FOLLOWUP] Update SqlConf version for nanos as long configuration [SPARK-40819][SQL][FOLLOWUP] Update SqlConf version for nanosAsLong configuration Feb 8, 2023
@awdavidson
Copy link
Contributor Author

PR title should be [SPARK-40819][SQL][FOLLOWUP]...

And the pr title and description a little difficult to understand for me if I didn't look at the changes ...

No problem - updated both title and description. Hoping the clarifies the change

HyukjinKwon pushed a commit that referenced this pull request Feb 9, 2023
…onfiguration

As requested by HyukjinKwon in #38312  NB: This change needs to be backported

### What changes were proposed in this pull request?

Update version set for "spark.sql.legacy.parquet.nanosAsLong"  configuration in SqlConf. This update is required because the previous PR set version to `3.2.3` which has already been released. Updating to version `3.2.4` will correctly reflect when this configuration element was added

### Why are the changes needed?

Correctness and to complete SPARK-40819

### Does this PR introduce _any_ user-facing change?

No, this is merely so this configuration element has the correct version

### How was this patch tested?

N/A

Closes #39943 from awdavidson/SPARK-40819_sql-conf.

Authored-by: awdavidson <54780428+awdavidson@users.noreply.github.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit 409c661)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
HyukjinKwon pushed a commit that referenced this pull request Feb 9, 2023
…onfiguration

As requested by HyukjinKwon in #38312  NB: This change needs to be backported

### What changes were proposed in this pull request?

Update version set for "spark.sql.legacy.parquet.nanosAsLong"  configuration in SqlConf. This update is required because the previous PR set version to `3.2.3` which has already been released. Updating to version `3.2.4` will correctly reflect when this configuration element was added

### Why are the changes needed?

Correctness and to complete SPARK-40819

### Does this PR introduce _any_ user-facing change?

No, this is merely so this configuration element has the correct version

### How was this patch tested?

N/A

Closes #39943 from awdavidson/SPARK-40819_sql-conf.

Authored-by: awdavidson <54780428+awdavidson@users.noreply.github.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit 409c661)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
@HyukjinKwon
Copy link
Member

Merged to master, branch-3.4, branch-3.3 and branch-3.2.

HyukjinKwon pushed a commit that referenced this pull request Feb 9, 2023
…onfiguration

As requested by HyukjinKwon in #38312  NB: This change needs to be backported

### What changes were proposed in this pull request?

Update version set for "spark.sql.legacy.parquet.nanosAsLong"  configuration in SqlConf. This update is required because the previous PR set version to `3.2.3` which has already been released. Updating to version `3.2.4` will correctly reflect when this configuration element was added

### Why are the changes needed?

Correctness and to complete SPARK-40819

### Does this PR introduce _any_ user-facing change?

No, this is merely so this configuration element has the correct version

### How was this patch tested?

N/A

Closes #39943 from awdavidson/SPARK-40819_sql-conf.

Authored-by: awdavidson <54780428+awdavidson@users.noreply.github.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit 409c661)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
sunchao pushed a commit to sunchao/spark that referenced this pull request Jun 2, 2023
…onfiguration

As requested by HyukjinKwon in apache#38312  NB: This change needs to be backported

### What changes were proposed in this pull request?

Update version set for "spark.sql.legacy.parquet.nanosAsLong"  configuration in SqlConf. This update is required because the previous PR set version to `3.2.3` which has already been released. Updating to version `3.2.4` will correctly reflect when this configuration element was added

### Why are the changes needed?

Correctness and to complete SPARK-40819

### Does this PR introduce _any_ user-facing change?

No, this is merely so this configuration element has the correct version

### How was this patch tested?

N/A

Closes apache#39943 from awdavidson/SPARK-40819_sql-conf.

Authored-by: awdavidson <54780428+awdavidson@users.noreply.github.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit 409c661)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
snmvaughan pushed a commit to snmvaughan/spark that referenced this pull request Jun 20, 2023
…onfiguration

As requested by HyukjinKwon in apache#38312  NB: This change needs to be backported

### What changes were proposed in this pull request?

Update version set for "spark.sql.legacy.parquet.nanosAsLong"  configuration in SqlConf. This update is required because the previous PR set version to `3.2.3` which has already been released. Updating to version `3.2.4` will correctly reflect when this configuration element was added

### Why are the changes needed?

Correctness and to complete SPARK-40819

### Does this PR introduce _any_ user-facing change?

No, this is merely so this configuration element has the correct version

### How was this patch tested?

N/A

Closes apache#39943 from awdavidson/SPARK-40819_sql-conf.

Authored-by: awdavidson <54780428+awdavidson@users.noreply.github.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
(cherry picked from commit 409c661)
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants