[SPARK-43394][BUILD] Upgrade maven to 3.8.8 #41073
Conversation
|
cc @srowen |
|
It's probably OK (re-run the tests?) |
|
GA passed, the |
docs/building-spark.md
Outdated
|
|
||
| The Maven-based build is the build of reference for Apache Spark. | ||
| Building Spark using Maven requires Maven 3.8.7 and Java 8. | ||
| Building Spark using Maven requires Maven 3.8.8 and Java 8. |
There was a problem hiding this comment.
Do we think 3.8.8 is required? I'd imagine 3.8.7 still works fine
There was a problem hiding this comment.
Based on the comments in #22781, I think we should change it to
Building Spark using Maven requires Maven 3.8.8 and Java 8/11/17.
because only the above versions were tested
There was a problem hiding this comment.
I think Maven 3.8.7 should work well, but w/o CI verification, it may break silently in anytime.
|
|
||
| The Maven-based build is the build of reference for Apache Spark. | ||
| Building Spark using Maven requires Maven 3.8.7 and Java 8. | ||
| Building Spark using Maven requires Maven 3.8.8 and Java 8/11/17. |
There was a problem hiding this comment.
Why do you touch 8/11/17 in this PR? Could you remove it from this PR, @pan3793 ?
There was a problem hiding this comment.
#22781 changed the content from "Java 8+" to "Java 8" because
Since we didn't test Java 9 ~ 11 up to now in the community
Currently, the GA tests building Spark using Maven w/ Java 8/11/17, so change it accordingly
|
Merged to master |
### What changes were proposed in this pull request? Upgrade Maven from 3.8.7 to 3.8.8. ### Why are the changes needed? Maven 3.8.8 is the latest patched version of 3.8.x https://maven.apache.org/docs/3.8.8/release-notes.html ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GA. Closes apache#41073 from pan3793/SPARK-43394. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Sean Owen <srowen@gmail.com>
### What changes were proposed in this pull request? Upgrade Maven from 3.8.7 to 3.8.8. ### Why are the changes needed? Maven 3.8.8 is the latest patched version of 3.8.x https://maven.apache.org/docs/3.8.8/release-notes.html ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GA. Closes apache#41073 from pan3793/SPARK-43394. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Sean Owen <srowen@gmail.com>
|
During Apache Spark 3.4.2 RC1 release, I found that |
Upgrade Maven from 3.8.7 to 3.8.8. Maven 3.8.8 is the latest patched version of 3.8.x https://maven.apache.org/docs/3.8.8/release-notes.html No Pass GA. Closes #41073 from pan3793/SPARK-43394. Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Sean Owen <srowen@gmail.com> (cherry picked from commit 04ef3d5) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
4 participants
What changes were proposed in this pull request?
Upgrade Maven from 3.8.7 to 3.8.8.
Why are the changes needed?
Maven 3.8.8 is the latest patched version of 3.8.x
https://maven.apache.org/docs/3.8.8/release-notes.html
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GA.