[SPARK-43348][PYTHON][TESTS][FOLLOW-UP] Skip the day-time-interval test only with PyPy 3.8 #41085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
changed the title
Member
Author
dongjoon-hyun
approved these changes
May 8, 2023
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you.
Sorry for the late recovery.
Member
|
Could you re-trigger the failed linter tests? It looks irrelevant. |
Member
Author
|
^ That should be fixed by #41086. |
Member
Author
|
But let me retrigger anyway .. seems another test got stuck .. |
Member
Author
|
Merged to master. |
Member
|
Thank you! |
LuciferYang
pushed a commit
to LuciferYang/spark
that referenced
this pull request
May 10, 2023
…st only with PyPy 3.8 ### What changes were proposed in this pull request? This PR is a followup of apache#41024 that skips the test only with PyPy 3.8. ### Why are the changes needed? To narrow the scope of testing skipped. ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? CI in this PR should verify the change. Closes apache#41085 from HyukjinKwon/SPARK-43354-followup. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a followup of #41024 that skips the test only with PyPy 3.8.
Why are the changes needed?
To narrow the scope of testing skipped.
Does this PR introduce any user-facing change?
No, test-only.
How was this patch tested?
CI in this PR should verify the change.