[SPARK-43611][SPARK-44602][SQL][PS][CONNCECT][3.5] Make ExtractWindowExpressions & WidenSetOperationTypes retain the PLAN_ID_TAG
#42252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the `PLAN_ID_TAG` ### What changes were proposed in this pull request? Make rule `ExtractWindowExpressions` retain the `PLAN_ID_TAG ` ### Why are the changes needed? In apache#39925, we introduced a new mechanism to resolve expression with specified plan. However, sometimes the plan ID might be discarded by some analyzer rules, and then some expressions can not be correctly resolved, this issue is the main blocker of PS on Connect. ### Does this PR introduce _any_ user-facing change? yes, a lot of Pandas APIs enabled ### How was this patch tested? Enable UTs Closes apache#42086 from zhengruifeng/ps_connect_analyze_window. Authored-by: Ruifeng Zheng <ruifengz@apache.org> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Contributor
Author
|
cc @HyukjinKwon @zhengruifeng FYI |
HyukjinKwon
approved these changes
Aug 1, 2023
zhengruifeng
approved these changes
Aug 1, 2023
zhengruifeng
added a commit
that referenced
this pull request
Aug 1, 2023
…wExpressions` & `WidenSetOperationTypes` retain the `PLAN_ID_TAG` ### What changes were proposed in this pull request? Backport for #42086 and #42230 ### Why are the changes needed? for functionality parity ### Does this PR introduce _any_ user-facing change? Enabling couple of pandas APIs ### How was this patch tested? Enabling the existing UTs Closes #42252 from itholic/SPARK-43611-3.5. Lead-authored-by: Ruifeng Zheng <ruifengz@apache.org> Co-authored-by: itholic <haejoon.lee@databricks.com> Signed-off-by: Ruifeng Zheng <ruifengz@apache.org>
Contributor
|
thanks, merged to branch-3.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Backport for #42086 and #42230
Why are the changes needed?
for functionality parity
Does this PR introduce any user-facing change?
Enabling couple of pandas APIs
How was this patch tested?
Enabling the existing UTs