[SPARK-45529][SS][TESTS] Decrease flakiness by ignore zero offset(wip)#43362
Closed
dengziming wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-45529][SS][TESTS] Decrease flakiness by ignore zero offset(wip)#43362dengziming wants to merge 1 commit intoapache:masterfrom
dengziming wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
@dongjoon-hyun We can make it much more stable after we use equalsIgnoreZeroOffset, however, this change will make |
dbff47f to
8ef9767
Compare
Contributor
|
https://github.com/dengziming/spark/actions/runs/6506157421/job/17671193820 |
Member
Author
|
We plan to upgrade Kafka to 3.6.1 later, the problem has been located, I closed this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Improve the infamous
KafkaSourceStressSuite, I find there are more than one reason for this problem, the most frequently failure path is: [XXX, Add partition, CheckAnswer], I guess we are not granted to get offsets from empty partitions when fetching data inMicroBatchExecution.I run the test locally more than 10 times and they are all successful after made this change, I even increased iterations from 50 to 100 and it only failed once in more than 10 times.
Why are the changes needed?
To make test less flaky, at least 90% more reliable the before. however, it's still possible to fail since I find some other reason
Does this PR introduce any user-facing change?
No
How was this patch tested?
Github CI
Was this patch authored or co-authored using generative AI tooling?
No