-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-43255][SQL] Replace the error class _LEGACY_ERROR_TEMP_2020 by an internal error #45302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…an internal error
|
If I am not wrong: I saw in the past users use |
|
cc @MaxGekk |
|
@MaxGekk To me it seems correct to make it an internal error. I think the cases it could come up from using user defined types in the Scala API are meant to be captured earlier by other code and it failing with this would indicate a spark bug.
My understanding is that classes |
|
@JinHelin404 Do you have an account at OSS JIRA: https://issues.apache.org/jira/browse/SPARK-43255? If so, please, leave a comment in the ticket (I will assign it to you) otherwise submit a request for the account. |
@MaxGekk I have left a comment. |
|
+1, LGTM. Merging to master. |
… an internal error ### What changes were proposed in this pull request? Change the error class_LEGACY_ERROR_TEMP_2022 to internal error as it cannot be accessed by public API. ### Why are the changes needed? User experience improvement ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Tests already exist. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#45302 from JinHelin404/SPARK-43255. Authored-by: JineHelin404 <605188046@qq.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
… an internal error ### What changes were proposed in this pull request? Change the error class_LEGACY_ERROR_TEMP_2022 to internal error as it cannot be accessed by public API. ### Why are the changes needed? User experience improvement ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Tests already exist. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#45302 from JinHelin404/SPARK-43255. Authored-by: JineHelin404 <605188046@qq.com> Signed-off-by: Max Gekk <max.gekk@gmail.com>
What changes were proposed in this pull request?
Change the error class_LEGACY_ERROR_TEMP_2022 to internal error as it cannot be accessed by public API.
Why are the changes needed?
User experience improvement
Does this PR introduce any user-facing change?
No
How was this patch tested?
Tests already exist.
Was this patch authored or co-authored using generative AI tooling?
No