Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Mar 19, 2024

What changes were proposed in this pull request?

This PR aims to fix IsolatedClientLoader.supportsHadoopShadedClient to handle Hadoop 3.4+ correctly.

Why are the changes needed?

Apache Spark 3.4+ support shaded clients, but currently supportsHadoopShadedClient returns false.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manual review.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the SQL label Mar 19, 2024
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-47457][CORE] Fix IsolatedClientLoader.supportsHadoopShadedClient to handle Hadoop 3.4+ [SPARK-47457][SQL] Fix IsolatedClientLoader.supportsHadoopShadedClient to handle Hadoop 3.4+ Mar 19, 2024
Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@yaooqinn
Copy link
Member

Hi @dongjoon-hyun. Can you fix the failed test?

[info] - SPARK-32212: test supportHadoopShadedClient() *** FAILED *** (3 milliseconds)
[info]   IsolatedClientLoader.supportsHadoopShadedClient(version) was true version 4 (HadoopVersionInfoSuite.scala:81)
[info]   org.scalatest.exceptions.TestFailedException:
[info]   at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
[info]   at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
[info]   at org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1231)
[info]   at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:1295)
[info]   at org.apache.spark.sql.hive.client.HadoopVersionInfoSuite.$anonfun$new$8(HadoopVersionInfoSuite.scala:81)

@dongjoon-hyun
Copy link
Member Author

Thank you, @yaooqinn and @LuciferYang . I fixed the last failure.

$ build/sbt "hive/testOnly *.HadoopVersionInfoSuite -z SPARK-32212" -Phive
...
[info] - SPARK-32256: Hadoop VersionInfo should be preloaded (36 seconds, 981 milliseconds)
[info] - SPARK-32212: test supportHadoopShadedClient() (2 milliseconds)
[info] - SPARK-32212: built-in Hadoop version should support shaded client (1 millisecond)
...
[info] Run completed in 37 seconds, 730 milliseconds.
[info] Total number of tests run: 3
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 3, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 49 s, completed Mar 19, 2024, 7:47:45 AM

@dongjoon-hyun
Copy link
Member Author

Merged to master for Apache Spark 4.0.0.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-47457 branch March 19, 2024 14:49
tobiasstadler pushed a commit to tobiasstadler/spark that referenced this pull request Mar 21, 2024
…nt` to handle Hadoop 3.4+

### What changes were proposed in this pull request?

This PR aims to fix `IsolatedClientLoader.supportsHadoopShadedClient` to handle Hadoop 3.4+ correctly.

### Why are the changes needed?

Apache Spark 3.4+ support shaded clients, but currently `supportsHadoopShadedClient` returns `false`.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Manual review.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#45585 from dongjoon-hyun/SPARK-47457.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants