[SPARK-47521][CORE] Use Utils.tryWithResource during reading shuffle data from external storage
#45663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from external storage.
dongjoon-hyun
changed the title
Utils.tryWithResource during reading shuffle data from external storage.
dongjoon-hyun
approved these changes
Mar 22, 2024
Member
There was a problem hiding this comment.
+1, LGTM. Thank you, @maheshk114 .
Merged to master/3.5/3.4 for Apache Spark 4.0.0/3.5.2/3.4.3.
dongjoon-hyun
changed the title
Utils.tryWithResource during reading shuffle data from external storage.Utils.tryWithResource during reading shuffle data from external storage
dongjoon-hyun
pushed a commit
that referenced
this pull request
Mar 22, 2024
…e data from external storage ### What changes were proposed in this pull request? In method FallbackStorage.open, file open is guarded by Utils.tryWithResource to avoid file handle leakage incase of failure during read. ### Why are the changes needed? To avoid file handle leakage in case of read failure. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing UTs ### Was this patch authored or co-authored using generative AI tooling? No Closes #45663 from maheshk114/SPARK-47521. Authored-by: maheshbehera <maheshbehera@microsoft.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit 2456690) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Mar 22, 2024
…e data from external storage ### What changes were proposed in this pull request? In method FallbackStorage.open, file open is guarded by Utils.tryWithResource to avoid file handle leakage incase of failure during read. ### Why are the changes needed? To avoid file handle leakage in case of read failure. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing UTs ### Was this patch authored or co-authored using generative AI tooling? No Closes #45663 from maheshk114/SPARK-47521. Authored-by: maheshbehera <maheshbehera@microsoft.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com> (cherry picked from commit 2456690) Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Member
|
Welcome to the Apache Spark community. Congratulations for your first commit. |
Author
Thanks a lot :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In method FallbackStorage.open, file open is guarded by Utils.tryWithResource to avoid file handle leakage incase of failure during read.
Why are the changes needed?
To avoid file handle leakage in case of read failure.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing UTs
Was this patch authored or co-authored using generative AI tooling?
No