[SPARK-48817][SQL] Eagerly execute union multi commands together #47224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
It seems to be caused by #32513 |
Member
Author
|
@cloud-fan @beliefer Could you please take a look? |
ulysses-you
reviewed
Jul 8, 2024
Contributor
ulysses-you
left a comment
ulysses-you
left a comment
There was a problem hiding this comment.
lgtm except some minor comments
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
Outdated
Show resolved
Hide resolved
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
Outdated
Show resolved
Hide resolved
ulysses-you
approved these changes
Jul 8, 2024
Contributor
|
thanks, merged to master |
Contributor
|
late LGTM |
jingz-db
pushed a commit
to jingz-db/spark
that referenced
this pull request
Jul 22, 2024
### What changes were proposed in this pull request? Eagerly execute union multi commands together. ### Why are the changes needed? MultiInsert is split to multiple sql executions, resulting in no exchange reuse. Reproduce sql: ``` create table wangzhen_t1(c1 int); create table wangzhen_t2(c1 int); create table wangzhen_t3(c1 int); insert into wangzhen_t1 values (1), (2), (3); from (select /*+ REPARTITION(3) */ c1 from wangzhen_t1) insert overwrite table wangzhen_t2 select c1 insert overwrite table wangzhen_t3 select c1; ``` In Spark 3.1, there is only one SQL execution and there is a reuse exchange.  However, in Spark 3.5, it was split to multiple executions and there was no ReuseExchange.   ### Does this PR introduce _any_ user-facing change? yes, multi inserts will executed in one execution. ### How was this patch tested? added unit test ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47224 from wForget/SPARK-48817. Authored-by: wforget <643348094@qq.com> Signed-off-by: youxiduo <youxiduo@corp.netease.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Eagerly execute union multi commands together.
Why are the changes needed?
MultiInsert is split to multiple sql executions, resulting in no exchange reuse.
Reproduce sql:
In Spark 3.1, there is only one SQL execution and there is a reuse exchange.
However, in Spark 3.5, it was split to multiple executions and there was no ReuseExchange.
Does this PR introduce any user-facing change?
yes, multi inserts will executed in one execution.
How was this patch tested?
added unit test
Was this patch authored or co-authored using generative AI tooling?
No