[SPARK-49410][SQL][TESTS] Update collation benchmarks#47893
Closed
uros-db wants to merge 5 commits intoapache:masterfrom
Closed
[SPARK-49410][SQL][TESTS] Update collation benchmarks#47893uros-db wants to merge 5 commits intoapache:masterfrom
uros-db wants to merge 5 commits intoapache:masterfrom
Conversation
dongjoon-hyun
requested changes
Aug 27, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Please regenerate and attach the result, @uros-db .
dongjoon-hyun
changed the title
MaxGekk
requested changes
Aug 28, 2024
Member
|
@uros-db Please, regenerate benchmark results for Java 17/21, see: |
MaxGekk
reviewed
Aug 29, 2024
MaxGekk
approved these changes
Aug 29, 2024
Member
|
+1, LGTM. Merging to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Updating collation benchmarks to compute relative time, instead of relative speed. Also, re-run all collation benchmarks (after introducing various perf improvements as part of the recent collation effort).
Why are the changes needed?
Relative speed is displayed in format: "x0.0" for collations that are slower than the referent collation (UTF8_BINARY).
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.
Was this patch authored or co-authored using generative AI tooling?
No.